Skip to content

Fdl unit tests #9511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldhosembabu merged 6 commits into from
Mar 23, 2022
Merged

Fdl unit tests #9511

eldhosembabu merged 6 commits into from
Mar 23, 2022

Conversation

@eldhosembabu
Copy link
Contributor

@eldhosembabu eldhosembabu commented Mar 23, 2022 •
edited
Loading

Adding more unit tests to validate custom domain logic

#no-changelog

Related issue : #6978

@eldhosembabu eldhosembabu requested a review from paulb777 March 23, 2022 19:35
@google-oss-bot
Copy link

google-oss-bot commented Mar 23, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseDynamicLinks

    TypeBase (6911d52)Merge (c83379d)Diff
    CocoaPods?403 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jdw0ZnICjd.html

@google-oss-bot
Copy link

google-oss-bot commented Mar 23, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from ? (6911d52) to 60.39% (c83379d) by ?.

    15 individual files with coverage change

    FilenameBase (6911d52)Merge (c83379d)Diff
    FDLDeviceHeuristicsHelper.m?0.00%?
    FDLLogging.m?58.62%?
    FDLURLComponents.m?81.95%?
    FDLUtilities.m?73.19%?
    FIRDLDefaultRetrievalProcessV2.m?14.04%?
    FIRDLJavaScriptExecutor.m?23.26%?
    FIRDLRetrievalProcessFactory.m?100.00%?
    FIRDLRetrievalProcessResult.m?100.00%?
    FIRDLScionLogging.m?100.00%?
    FIRDynamicLink.m?77.78%?
    FIRDynamicLinkComponentsKeyProvider.m?66.67%?
    FIRDynamicLinkNetworking.m?44.10%?
    FIRDynamicLinks.m?69.10%?
    GINArgument.m?0.00%?
    GINInvocation.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fIYEes88Bs.html

@eldhosembabu eldhosembabu merged commit 6efe4f5 into master Mar 23, 2022
@eldhosembabu eldhosembabu deleted the fdl-unit-tests branch March 23, 2022 20:36
@firebase firebase locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

api: dynamiclinks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldhosembabu @google-oss-bot @paulb777