Skip to content

fix: collisions in artifact names from re-usable catalyst job #15709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 3 commits into from
Jan 13, 2026
Merged

fix: collisions in artifact names from re-usable catalyst job #15709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbec711
fix: collisions in artifact names from re-usable catalyst job
ncooke3 Jan 13, 2026
ef123ee
shared timestamp
ncooke3 Jan 13, 2026
6866d24
Make firebasecore trigger recursive
ncooke3 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sdk.core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- '.github/workflows/_cocoapods.yml'
- '.github/workflows/_catalyst.yml'
- '.github/workflows/_cocoapods.cron.yml'
- 'scripts/' # Smoke test changes in `scripts/`.
- 'scripts/**' # Smoke test changes in `scripts/`.
- 'Gemfile*'
schedule:
# Run every day at 3am (PDT) / 6am (EDT) - cron uses UTC times
Expand Down
7 changes: 5 additions & 2 deletions scripts/test_catalyst.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ else
scheme="$pod"
fi

# Define timestamp before args array
timestamp=$(date +%s)

bundle exec pod gen --local-sources=./ --sources=https://github.com/firebase/SpecsDev.git,https://github.com/firebase/SpecsStaging.git,https://cdn.cocoapods.org/ \
"$pod".podspec --platforms=ios

Expand All @@ -57,10 +60,10 @@ args=(
"CODE_SIGN_IDENTITY=-" "CODE_SIGNING_REQUIRED=NO" "CODE_SIGNING_ALLOWED=NO"
# GHA is still running 10.15.
"MACOSX_DEPLOYMENT_TARGET=10.15"
"-resultBundlePath" "xcresults/$scheme.xcresult"
"-resultBundlePath" "xcresults/$scheme-${timestamp}.xcresult"
)

xcodebuild -version
gem install xcpretty
log_filename="xcodebuild-${build_mode}.log"
log_filename="xcodebuild-${build_mode}-${timestamp}.log"
xcodebuild "${args[@]}" | tee "$log_filename" | xcpretty
Loading