fix: collisions in artifact names from re-usable catalyst job#15709
fix: collisions in artifact names from re-usable catalyst job#15709
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request fixes potential artifact name collisions in the catalyst test job by appending a Unix timestamp to the result bundle and log file names. The change is correct and addresses the issue. I have one minor suggestion to ensure the same timestamp is used for both files for better consistency.
|
Interesting, the sdk.core.yml trigger for catalyst script changes, from #15699, doesn't seem to be working. |
Pushed 6866d24 to do a one-off trigger and maybe(?) fix this for next time. I thought the |
Fix #15701
#no-changelog