Skip to content

fix: collisions in artifact names from re-usable catalyst job#15709

Merged
ncooke3 merged 3 commits intomainfrom
nc/fix-cat-artifact-names
Jan 13, 2026
Merged

fix: collisions in artifact names from re-usable catalyst job#15709
ncooke3 merged 3 commits intomainfrom
nc/fix-cat-artifact-names

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 13, 2026

Fix #15701

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3 ncooke3 mentioned this pull request Jan 13, 2026
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 13, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes potential artifact name collisions in the catalyst test job by appending a Unix timestamp to the result bundle and log file names. The change is correct and addresses the issue. I have one minor suggestion to ensure the same timestamp is used for both files for better consistency.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 13, 2026

Interesting, the sdk.core.yml trigger for catalyst script changes, from #15699, doesn't seem to be working.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 13, 2026

Interesting, the sdk.core.yml trigger for catalyst script changes, from #15699, doesn't seem to be working.

Pushed 6866d24 to do a one-off trigger and maybe(?) fix this for next time. I thought the - 'scripts/' trigger would be sufficient to trigger from a change in top-level scripts/test_catalyst.sh, but maybe not.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 13, 2026

@ncooke3 ncooke3 marked this pull request as ready for review January 13, 2026 16:21
@ncooke3 ncooke3 requested a review from a team as a code owner January 13, 2026 16:21
@ncooke3 ncooke3 enabled auto-merge (squash) January 13, 2026 16:21
@ncooke3 ncooke3 merged commit 015698a into main Jan 13, 2026
51 checks passed
@ncooke3 ncooke3 deleted the nc/fix-cat-artifact-names branch January 13, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly Testing Report

2 participants