Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todos and workarounds for tests not yet ready for macos-14 #12781

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 13, 2024

Fix #12779

Follow up to #12746 to address issues caught in nightlies

#no-changelog

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (70f7e77) to 88.19% (a79e98c) by +0.04%.

    FilenameBase (70f7e77)Merge (a79e98c)Diff
    exception.cc23.68%84.21%+60.53%
    grpc_nanopb.cc94.87%100.00%+5.13%
    grpc_stream.cc99.01%98.02%-0.99%
    leveldb_index_manager.cc97.73%97.31%-0.42%
    leveldb_key.cc99.02%98.53%-0.49%
    leveldb_mutation_queue.cc93.56%92.42%-1.14%
    leveldb_util.cc100.00%71.43%-28.57%
    watch_stream.cc90.70%95.35%+4.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k8o45YeEUx.html

@ncooke3
Copy link
Member

ncooke3 commented Apr 14, 2024

Going to merge for the nightly!

@ncooke3 ncooke3 merged commit 4e9d357 into main Apr 14, 2024
93 checks passed
@ncooke3 ncooke3 deleted the pb-macos14-not-yet branch April 14, 2024 01:25
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request May 1, 2024
….25.0" (#1056)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk)
| minor | `from: "10.24.0"` -> `from: "10.25.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.25.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.25.0):
Firebase Apple 10.25.0

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.24.0...10.25.0)

The Firebase Apple SDK (10.25.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.25.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[FirebaseCoreInternal] Switch to implementation-only import of GULs
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12714
- \[AppCheck, Database, InAppMessaging, MLModelDownloader, Performance,
Sessions] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[#&#8203;12752](https://github.com/firebase/firebase-ios-sdk/issues/12752),
[#&#8203;12753](https://github.com/firebase/firebase-ios-sdk/issues/12753),
[#&#8203;12757](https://github.com/firebase/firebase-ios-sdk/issues/12757),
[#&#8203;12759](https://github.com/firebase/firebase-ios-sdk/issues/12759),
[#&#8203;12762](https://github.com/firebase/firebase-ios-sdk/issues/12762),
[#&#8203;12773](https://github.com/firebase/firebase-ios-sdk/issues/12773)
- Use declspec in Firestore on Windows machines by
[@&#8203;a-maurice](https://github.com/a-maurice) in
[firebase/firebase-ios-sdk#12758
- \[CI] Stop Xcode 14, start Xcode 15.3 by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12746
- \[Performance] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12759
- Todos and workarounds for tests not yet ready for macos-14 by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12781
- Another macos-14 CI workaround by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12787
- \[CI] Update grpc dependent jobs to macos-14 by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12790
- \[Firestore] Remove DocumentID setter warning by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[firebase/firebase-ios-sdk#12756
- \[App Check] Bump dependency on AppCheckCore to 10.19.0+ by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12806
- Allow Blob of data with zero length. by
[@&#8203;tom-andersen](https://github.com/tom-andersen) in
[firebase/firebase-ios-sdk#12694
- \[Infra] Switch zip building over to Xcode 15.2 by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12737
- Make use of
SQLITE_OPEN_FILEPROTECTION_COMPLETEUNTILFIRSTUSERAUTHENTICATION
conditional. by
[@&#8203;cprince-foreflight](https://github.com/cprince-foreflight) in
[firebase/firebase-ios-sdk#12548
- \[Release Tooling] Consistent approach to resources when building on
Xcode 15 by [@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12821
- \[Release Tooling] Cleanup unused folder references by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12825
- Analytics 10.25.0 by [@&#8203;pcfba](https://github.com/pcfba) in
[firebase/firebase-ios-sdk#12843
- Update `FIRAuthInterop` to use `_Nullable_result` annotation by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[firebase/firebase-ios-sdk#12841
- Disable quickstart CI that doesn't work with Xcode 15 by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12846

#### New Contributors

- [@&#8203;mrs1669](https://github.com/mrs1669) made their first
contribution in
[firebase/firebase-ios-sdk#12760
- [@&#8203;a-maurice](https://github.com/a-maurice) made their first
contribution in
[firebase/firebase-ios-sdk#12758
- [@&#8203;cprince-foreflight](https://github.com/cprince-foreflight)
made their first contribution in
[firebase/firebase-ios-sdk#12548

**Full Changelog**:
firebase/firebase-ios-sdk@10.24.0...10.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants