[Performance] Migrate to GoogleUtilities's storage container #12759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Apr 11, 2024
Coverage Report 1Affected Products
Test Logs |
|
The changes look good to me. But there are scenarios we might need to validate before landing these changes. Eg: We cache certain configs until the next launch which control the volume of events. With this new change, I'm worried that the volume of events might shoot up until the next config fetch happens. Is this time sensitive? |
|
Thanks, @visumickey. This change is targeting next release (code freeze: ~4/23). edit: Here are |
visumickey
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Thanks for making the change. Since both NSUserDefaults and GULUserDefaults points to the same storage underneath, this change is harmless.
Here is the reference to the unit tests that gives the confidence that there would not be any impact because of this change.
Approving for merge.
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
May 1, 2024
….25.0" (#1056) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk) | minor | `from: "10.24.0"` -> `from: "10.25.0"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v10.25.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.25.0): Firebase Apple 10.25.0 [Compare Source](https://github.com/firebase/firebase-ios-sdk/compare/10.24.0...10.25.0) The Firebase Apple SDK (10.25.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.25.0) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) #### What's Changed - \[FirebaseCoreInternal] Switch to implementation-only import of GULs by [@​ncooke3](https://github.com/ncooke3) in [firebase/firebase-ios-sdk#12714 - \[AppCheck, Database, InAppMessaging, MLModelDownloader, Performance, Sessions] Migrate to GoogleUtilities's storage container by [@​ncooke3](https://github.com/ncooke3) in [#​12752](https://github.com/firebase/firebase-ios-sdk/issues/12752), [#​12753](https://github.com/firebase/firebase-ios-sdk/issues/12753), [#​12757](https://github.com/firebase/firebase-ios-sdk/issues/12757), [#​12759](https://github.com/firebase/firebase-ios-sdk/issues/12759), [#​12762](https://github.com/firebase/firebase-ios-sdk/issues/12762), [#​12773](https://github.com/firebase/firebase-ios-sdk/issues/12773) - Use declspec in Firestore on Windows machines by [@​a-maurice](https://github.com/a-maurice) in [firebase/firebase-ios-sdk#12758 - \[CI] Stop Xcode 14, start Xcode 15.3 by [@​paulb777](https://github.com/paulb777) in [firebase/firebase-ios-sdk#12746 - \[Performance] Migrate to GoogleUtilities's storage container by [@​ncooke3](https://github.com/ncooke3) in [firebase/firebase-ios-sdk#12759 - Todos and workarounds for tests not yet ready for macos-14 by [@​paulb777](https://github.com/paulb777) in [firebase/firebase-ios-sdk#12781 - Another macos-14 CI workaround by [@​paulb777](https://github.com/paulb777) in [firebase/firebase-ios-sdk#12787 - \[CI] Update grpc dependent jobs to macos-14 by [@​paulb777](https://github.com/paulb777) in [firebase/firebase-ios-sdk#12790 - \[Firestore] Remove DocumentID setter warning by [@​andrewheard](https://github.com/andrewheard) in [firebase/firebase-ios-sdk#12756 - \[App Check] Bump dependency on AppCheckCore to 10.19.0+ by [@​ncooke3](https://github.com/ncooke3) in [firebase/firebase-ios-sdk#12806 - Allow Blob of data with zero length. by [@​tom-andersen](https://github.com/tom-andersen) in [firebase/firebase-ios-sdk#12694 - \[Infra] Switch zip building over to Xcode 15.2 by [@​ncooke3](https://github.com/ncooke3) in [firebase/firebase-ios-sdk#12737 - Make use of SQLITE_OPEN_FILEPROTECTION_COMPLETEUNTILFIRSTUSERAUTHENTICATION conditional. by [@​cprince-foreflight](https://github.com/cprince-foreflight) in [firebase/firebase-ios-sdk#12548 - \[Release Tooling] Consistent approach to resources when building on Xcode 15 by [@​ncooke3](https://github.com/ncooke3) in [firebase/firebase-ios-sdk#12821 - \[Release Tooling] Cleanup unused folder references by [@​ncooke3](https://github.com/ncooke3) in [firebase/firebase-ios-sdk#12825 - Analytics 10.25.0 by [@​pcfba](https://github.com/pcfba) in [firebase/firebase-ios-sdk#12843 - Update `FIRAuthInterop` to use `_Nullable_result` annotation by [@​andrewheard](https://github.com/andrewheard) in [firebase/firebase-ios-sdk#12841 - Disable quickstart CI that doesn't work with Xcode 15 by [@​paulb777](https://github.com/paulb777) in [firebase/firebase-ios-sdk#12846 #### New Contributors - [@​mrs1669](https://github.com/mrs1669) made their first contribution in [firebase/firebase-ios-sdk#12760 - [@​a-maurice](https://github.com/a-maurice) made their first contribution in [firebase/firebase-ios-sdk#12758 - [@​cprince-foreflight](https://github.com/cprince-foreflight) made their first contribution in [firebase/firebase-ios-sdk#12548 **Full Changelog**: firebase/firebase-ios-sdk@10.24.0...10.25.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.