Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed Column UX bugs #257

Closed
texodus opened this issue Oct 3, 2018 · 4 comments
Closed

Computed Column UX bugs #257

texodus opened this issue Oct 3, 2018 · 4 comments
Assignees
@sc1f
Labels
bug Concrete, reproducible bugs

Comments

@texodus
Copy link
Member

texodus commented Oct 3, 2018

  • Column drop target flickers when a column is dragged out of the computed column selector
  • Selected columns are cleared when the computation type is changed
  • Duplicate named columns silently fail
  • Error messages are nice - but IMO we should replace these with just disabling the Save button if the inputs are invalid
  • Dark theme has some missing colors
@texodus texodus changed the title Computed Column feature bugs Computed Column UX bugs Oct 3, 2018
@texodus texodus added the bug Concrete, reproducible bugs label Oct 8, 2018
@sc1f sc1f self-assigned this Oct 12, 2018
sc1f added a commit that referenced this issue Oct 12, 2018
@sc1f
#257: remove error messages, disable save by default, fix dark theme
9412479
@sc1f
Copy link
Contributor

sc1f commented Oct 12, 2018

Fixed dark theme and removed error messages.

@sc1f
Copy link
Contributor

sc1f commented Oct 15, 2018

FIXED: If a column name is entered and then deleted, the column will no longer save and the save button will be disabled.

@sc1f
Copy link
Contributor

sc1f commented Oct 16, 2018

Fixed all issues.

@sc1f sc1f mentioned this issue Oct 16, 2018
Merged
texodus pushed a commit that referenced this issue Oct 25, 2018
@sc1f @texodus
#257: remove error messages, disable save by default, fix dark theme
7f7f811
texodus pushed a commit that referenced this issue Oct 25, 2018
@sc1f @texodus
#257: fix flickering on drop target, fix computation clearing input c…
ba6e1f3 
…olumns, fix duplicate naming issue
texodus pushed a commit that referenced this issue Oct 25, 2018
@sc1f @texodus
#257: flickering stop-gap fix, move drag-drop from row.js to utils.js
a06dc20
@texodus
Copy link
Member Author

texodus commented Oct 25, 2018

Merged

@texodus texodus closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc1f sc1f

Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@texodus @sc1f