Skip to content

Commit 9412479

Browse files
sc1fsc1f
committed
#257: remove error messages, disable save by default, fix dark theme
1 parent f087c2b commit 9412479

File tree

12 files changed

+86
-113
lines changed

12 files changed

+86
-113
lines changed

‎docs/perspective-viewer.md

+13-26
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,14 @@ names.
5454

5555
**Examples**
5656

57-
via Javascript DOM
58-
57+
_via Javascript DOM_
5958

6059
```javascript
6160
let elem = document.getElementById('my_viewer');
6261
elem.setAttribute('sort', JSON.stringify([["x","desc"]));
6362
```
6463

65-
via HTML
66-
64+
_via HTML_
6765

6866
```javascript
6967
<perspective-viewer sort='[["x","desc"]]'></perspective-viewer>
@@ -79,16 +77,14 @@ The set of visible columns.
7977

8078
**Examples**
8179

82-
via Javascript DOM
83-
80+
_via Javascript DOM_
8481

8582
```javascript
8683
let elem = document.getElementById('my_viewer');
8784
elem.setAttribute('columns', JSON.stringify(["x", "y'"]));
8885
```
8986

90-
via HTML
91-
87+
_via HTML_
9288

9389
```javascript
9490
<perspective-viewer columns='["x", "y"]'></perspective-viewer>
@@ -104,16 +100,14 @@ The set of visible columns.
104100

105101
**Examples**
106102

107-
via Javascript DOM
108-
103+
_via Javascript DOM_
109104

110105
```javascript
111106
let elem = document.getElementById('my_viewer');
112107
elem.setAttribute('computed-columns', JSON.stringify([{name: "x+y", func: "add", inputs: ["x", "y"]}]));
113108
```
114109

115-
via HTML
116-
110+
_via HTML_
117111

118112
```javascript
119113
<perspective-viewer computed-columns="[{name:'x+y',func:'add',inputs:['x','y']}]""></perspective-viewer>
@@ -133,16 +127,14 @@ The set of column aggregate configurations.
133127
134128
**Examples**
135129
136-
via Javascript DOM
137-
130+
_via Javascript DOM_
138131
139132
```javascript
140133
let elem = document.getElementById('my_viewer');
141134
elem.setAttribute('aggregates', JSON.stringify({x: "distinct count"}));
142135
```
143136
144-
via HTML
145-
137+
_via HTML_
146138
147139
```javascript
148140
<perspective-viewer aggregates='{"x": "distinct count"}'></perspective-viewer>
@@ -154,8 +146,7 @@ The set of column filter configurations.
154146
155147
**Examples**
156148
157-
via Javascript DOM
158-
149+
_via Javascript DOM_
159150
160151
```javascript
161152
let filters = [
@@ -166,8 +157,7 @@ let elem = document.getElementById('my_viewer');
166157
elem.setAttribute('filters', JSON.stringify(filters));
167158
```
168159
169-
via HTML
170-
160+
_via HTML_
171161
172162
```javascript
173163
<perspective-viewer filters='[["x", "<", 3], ["y", "contains", "abc"]]'></perspective-viewer>
@@ -239,8 +229,7 @@ element, its internal `perspective.table` will also be deleted.
239229
240230
**Examples**
241231
242-
Load JSON
243-
232+
_Load JSON_
244233
245234
```javascript
246235
const my_viewer = document.getElementById('#my_viewer');
@@ -250,16 +239,14 @@ my_viewer.load([
250239
]);
251240
```
252241
253-
Load CSV
254-
242+
_Load CSV_
255243
256244
```javascript
257245
const my_viewer = document.getElementById('#my_viewer');
258246
my_viewer.load("x,y\n1,a\n2,b");
259247
```
260248
261-
Load perspective.table
262-
249+
_Load perspective.table_
263250
264251
```javascript
265252
const my_viewer = document.getElementById('#my_viewer');

‎packages/perspective-viewer/README.md

+13-26
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,14 @@ names.
5454

5555
**Examples**
5656

57-
via Javascript DOM
58-
57+
_via Javascript DOM_
5958

6059
```javascript
6160
let elem = document.getElementById('my_viewer');
6261
elem.setAttribute('sort', JSON.stringify([["x","desc"]));
6362
```
6463

65-
via HTML
66-
64+
_via HTML_
6765

6866
```javascript
6967
<perspective-viewer sort='[["x","desc"]]'></perspective-viewer>
@@ -79,16 +77,14 @@ The set of visible columns.
7977

8078
**Examples**
8179

82-
via Javascript DOM
83-
80+
_via Javascript DOM_
8481

8582
```javascript
8683
let elem = document.getElementById('my_viewer');
8784
elem.setAttribute('columns', JSON.stringify(["x", "y'"]));
8885
```
8986

90-
via HTML
91-
87+
_via HTML_
9288

9389
```javascript
9490
<perspective-viewer columns='["x", "y"]'></perspective-viewer>
@@ -104,16 +100,14 @@ The set of visible columns.
104100

105101
**Examples**
106102

107-
via Javascript DOM
108-
103+
_via Javascript DOM_
109104

110105
```javascript
111106
let elem = document.getElementById('my_viewer');
112107
elem.setAttribute('computed-columns', JSON.stringify([{name: "x+y", func: "add", inputs: ["x", "y"]}]));
113108
```
114109

115-
via HTML
116-
110+
_via HTML_
117111

118112
```javascript
119113
<perspective-viewer computed-columns="[{name:'x+y',func:'add',inputs:['x','y']}]""></perspective-viewer>
@@ -133,16 +127,14 @@ The set of column aggregate configurations.
133127
134128
**Examples**
135129
136-
via Javascript DOM
137-
130+
_via Javascript DOM_
138131
139132
```javascript
140133
let elem = document.getElementById('my_viewer');
141134
elem.setAttribute('aggregates', JSON.stringify({x: "distinct count"}));
142135
```
143136
144-
via HTML
145-
137+
_via HTML_
146138
147139
```javascript
148140
<perspective-viewer aggregates='{"x": "distinct count"}'></perspective-viewer>
@@ -154,8 +146,7 @@ The set of column filter configurations.
154146
155147
**Examples**
156148
157-
via Javascript DOM
158-
149+
_via Javascript DOM_
159150
160151
```javascript
161152
let filters = [
@@ -166,8 +157,7 @@ let elem = document.getElementById('my_viewer');
166157
elem.setAttribute('filters', JSON.stringify(filters));
167158
```
168159
169-
via HTML
170-
160+
_via HTML_
171161
172162
```javascript
173163
<perspective-viewer filters='[["x", "<", 3], ["y", "contains", "abc"]]'></perspective-viewer>
@@ -239,8 +229,7 @@ element, its internal `perspective.table` will also be deleted.
239229
240230
**Examples**
241231
242-
Load JSON
243-
232+
_Load JSON_
244233
245234
```javascript
246235
const my_viewer = document.getElementById('#my_viewer');
@@ -250,16 +239,14 @@ my_viewer.load([
250239
]);
251240
```
252241
253-
Load CSV
254-
242+
_Load CSV_
255243
256244
```javascript
257245
const my_viewer = document.getElementById('#my_viewer');
258246
my_viewer.load("x,y\n1,a\n2,b");
259247
```
260248
261-
Load perspective.table
262-
249+
_Load perspective.table_
263250
264251
```javascript
265252
const my_viewer = document.getElementById('#my_viewer');

‎packages/perspective-viewer/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"build:webpack:cjs": "webpack --color --config src/config/view.cjs.config.js",
1717
"build:webpack:viewer": "webpack --color --config src/config/view.config.js",
1818
"build": "npm-run-all build:webpack:* build:themes:* copy:*",
19+
"watch": "webpack --color --watch --config src/config/view.config.js",
1920
"copy:worker": "cp -r node_modules/@jpmorganchase/perspective/build/*.worker.*.js build",
2021
"copy:sourcemaps": "cp -r node_modules/@jpmorganchase/perspective/build/*.worker.*.js.map build",
2122
"copy:wasm": "cp -r node_modules/@jpmorganchase/perspective/build/psp.async.wasm build",

‎packages/perspective-viewer/src/html/computed_column.html

+1-5
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,13 @@
2626
</div>
2727
</div>
2828
<div class="psp-cc__container" style="margin-top:-12px;">
29-
<span id="psp-cc__error--input" class="psp-cc__label psp-cc__error"></span>
3029
<div id="psp-cc-computation-inputs">
3130
<!--<div class="psp-cc-computation__input-column" drop-target ondragenter="dragEnter(event)"></div>-->
3231
</div>
3332
</div>
34-
<div class="psp-cc__container">
35-
<span id="psp-cc__error--save" class="psp-cc__label psp-cc__error"></span>
36-
</div>
3733
</div>
3834
<div id="psp-cc__actions">
3935
<button id="psp-cc-button-delete" class="psp-cc__button">Delete</button>
40-
<button id="psp-cc-button-save" class="psp-cc__button">Save</button>
36+
<button id="psp-cc-button-save" class="psp-cc__button" disabled>Save</button>
4137
</div>
4238
</template>

0 commit comments

Comments
 (0)