Add form support for ServiceStore embedded data#1171
Merged
MauricioUyaguari merged 1 commit intofinos:masterfrom May 20, 2022
Merged
Add form support for ServiceStore embedded data#1171MauricioUyaguari merged 1 commit intofinos:masterfrom
MauricioUyaguari merged 1 commit intofinos:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 6576374 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 42.48% 42.66% +0.17%
==========================================
Files 1133 1140 +7
Lines 50009 50232 +223
Branches 11432 11521 +89
==========================================
+ Hits 21247 21430 +183
- Misses 28692 28730 +38
- Partials 70 72 +2
|
gayathrir11
force-pushed
the
serviceStore_data
branch
2 times, most recently
from
15d582f to
458661d
Compare
gayathrir11
force-pushed
the
serviceStore_data
branch
from
458661d to
6576374
Compare
gayathrir11
requested review from
MauricioUyaguari,
akphi and
pierredebelen
as code owners
MauricioUyaguari
approved these changes
May 20, 2022
Member
MauricioUyaguari
left a comment
MauricioUyaguari
left a comment
There was a problem hiding this comment.
Merging (as i need it for my development :)) but please addess the minor comments.
| </div> | ||
| </div> | ||
| <div className="query-params-editor__content"> | ||
| {Array.from(serviceRequestPattern.queryParams?.values() ?? []).map( |
Member
There was a problem hiding this comment.
since you are using both keys and values in this map, could you keep it cleaner and use .entries() instead of .values()
| </div> | ||
| <div className="header-params-editor__content"> | ||
| {Array.from(serviceRequestPattern.headerParams?.values() ?? []).map( | ||
| (headerParam: StringValuePattern, index: number) => ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #1158
Data elementHow did you test this change?
serviceStore_data.mp4