remove Stubable and more metamodel simplifications
#1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 735414a The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
27 tasks
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
+ Coverage 42.78% 42.89% +0.11%
==========================================
Files 1132 1136 +4
Lines 50037 49891 -146
Branches 11441 11430 -11
==========================================
- Hits 21407 21401 -6
+ Misses 28559 28418 -141
- Partials 71 72 +1
|
akphi
force-pushed
the
stub
branch
2 times, most recently
from
d90861d to
609ab07
Compare
added 9 commits
May 12, 2022 14:23
MauricioUyaguari
approved these changes
May 12, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stubable/createStub/isStubfindPropertyMapping()out ofInstanceSetImplementationDSLsgetMilestoneTemporalStereotype()getEmbeddedSetImplmentations()fromInstanceSetImplementationIMPORTANTRenamefullPathtopathinPackage. Where this change really makes a difference is for the root package: previously,pathwas thenameof the root package element, from now on,pathwill beempty string, this makes the handling of root package when constructing element path more consistentIMPORTANTMove logic out of metamodels, such asClass.getProperty(),Database.getSchema(), etc. and expose them as helper methods.How did you test this change?