Upgrade to React 18 #1146
Merged
Upgrade to React 18 #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c4d9ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
==========================================
- Coverage 42.82% 42.81% -0.02%
==========================================
Files 1125 1125
Lines 49360 49368 +8
Branches 11274 11274
==========================================
- Hits 21137 21135 -2
- Misses 28153 28162 +9
- Partials 70 71 +1
|
MauricioUyaguari
approved these changes
May 9, 2022
akphi
pushed a commit
to akphi/legend-studio
that referenced
this pull request
May 10, 2022
akphi
pushed a commit
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
act()around state change calls else no propgation will be done - see React18 support mobxjs/mobx#3387@babel/plugin-proposal-class-propertiesnow that it's moved tostage 4setActionAlertInfo->setActionAlertInfoaction stateinChangeDetectionStateHow did you test this change?