Skip to content

Add form support for ExternalFormat embedded data#1133

Merged
MauricioUyaguari merged 4 commits intofinos:masterfrom
gayathrir11:embedded_data
May 9, 2022
Merged

Add form support for ExternalFormat embedded data#1133
MauricioUyaguari merged 4 commits intofinos:masterfrom
gayathrir11:embedded_data

Conversation

@gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented May 5, 2022

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
    pic1
    pic2
    pic3
external_format.mp4

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label May 5, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

🦋 Changeset detected

Latest commit: ece6ed4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-graph Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-studio Minor
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-manual-tests Patch
@finos/legend-query Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-query-app Patch
@finos/legend-taxonomy-app Patch
@finos/legend-studio-deployment Patch
@finos/legend-query-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gayathrir11 gayathrir11 force-pushed the embedded_data branch 2 times, most recently from 60cc220 to 174f031 Compare May 5, 2022 11:16
@MauricioUyaguari
Copy link
Member

Question on the UI.

  1. how are users chosing the type of embedded data ?
  2. For ModelStore Don't really see an editor in the screenshots :)

@gayathrir11 gayathrir11 marked this pull request as ready for review May 6, 2022 13:57
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1133 (80bc796) into master (27df808) will decrease coverage by 0.12%.
The diff coverage is 16.82%.

❗ Current head 80bc796 differs from pull request most recent head ece6ed4. Consider uploading reports for the commit ece6ed4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage   42.82%   42.70%   -0.13%     
==========================================
  Files        1125     1128       +3     
  Lines       49360    49568     +208     
  Branches    11274    11321      +47     
==========================================
+ Hits        21137    21166      +29     
- Misses      28153    28332     +179     
  Partials       70       70              
Impacted Files Coverage Δ
...ce/src/components/ESService_LegendStudioPlugin.tsx 13.18% <0.00%> (-0.30%) ⬇️
...dio/src/stores/editor-state/ExternalFormatState.ts 44.82% <0.00%> (-5.18%) ⬇️
...ckages/legend-studio/src/stores/NewElementState.ts 37.10% <4.00%> (-2.43%) ⬇️
...state/element-editor-state/data/DataEditorState.ts 6.52% <6.52%> (ø)
...ditor/edit-panel/data-editor/DataElementEditor.tsx 10.86% <10.86%> (ø)
...mponents/editor/side-bar/CreateNewElementModal.tsx 49.41% <22.22%> (-5.13%) ⬇️
...tores/graphModifier/DSLData_GraphModifierHelper.ts 33.33% <33.33%> (ø)
...dio/src/components/editor/edit-panel/EditPanel.tsx 59.09% <50.00%> (-0.14%) ⬇️
packages/legend-studio/src/stores/EditorStore.ts 48.01% <66.66%> (-0.10%) ⬇️
...ditor/edit-panel/uml-editor/StereotypeSelector.tsx 77.77% <100.00%> (+2.77%) ⬆️
... and 3 more

@MauricioUyaguari MauricioUyaguari merged commit bd86b7b into finos:master May 9, 2022
@gayathrir11 gayathrir11 deleted the embedded_data branch August 30, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-present CLA Signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants