support setting offset Source Information for grammar parser APIs#682
Merged
pierredebelen merged 6 commits intofinos:masterfrom May 20, 2022
Merged
support setting offset Source Information for grammar parser APIs#682pierredebelen merged 6 commits intofinos:masterfrom
Source Information for grammar parser APIs#682pierredebelen merged 6 commits intofinos:masterfrom
Conversation
sourceId for new grammar parser APIs
2e2db3b to
bb6cba6
Compare
sourceId for new grammar parser APIsSource Information for grammar parser APIs
7 tasks
rafaelbey
pushed a commit
to rafaelbey/legend-engine
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #595
Support setting
sourceIdfor value specification in new grammar parser APIs. Also did some minor cleanups. Instead of sending inStringand a separate optionalbooleanflag forreturnSourceInfo, we now bundle these and call the structureParserInputNOTE We leave
non-batchAPIs simple (taking everything asquery parameter) so that it's easier to use from REST design perspective, look at the Swagger screenshot below for exampleWe also cleanup the
grammar composerendpoints to now takeRENDER STYLEas aquery parameterinstead of apath parameterto be more consistent across all grammar APIs.