throw error when non-batch grammarToJson endpoints fail#595
Merged
pierredebelen merged 2 commits intofinos:masterfrom Mar 23, 2022
Merged
throw error when non-batch grammarToJson endpoints fail#595pierredebelen merged 2 commits intofinos:masterfrom
grammarToJson endpoints fail#595pierredebelen merged 2 commits intofinos:masterfrom
Conversation
akphi
requested review from
aormerod-gs,
davidharte-gs and
pierredebelen
as code owners
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies to non-batch
grammarToJsonendpoints:/grammarToJson/model/grammarToJson/valueSpecification/grammarToJson/lambda/grammarToJson/graphFetch/grammarToJson/relationalOperationElementWhen there's a parsing error, these endpoint return
200with the return body as the error. We should throw this error instead and I opt for using error code400: Bad Request