Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autocomplete for interactive mode #46

Merged
merged 8 commits into from
Dec 28, 2016

Conversation

Code-Hex
Copy link
Contributor

@Code-Hex Code-Hex commented Dec 24, 2016

What I did?

I have created complementary functionality in interactive mode #38
But I have something to do.

  • Create test for autocomplete.go
  • Simplifying autocomplete.go
  • In order not to end with log.Fatal etc, Allow all errors of runtime to be received from runtime.Run

I think @cloudson perform the last task earlier than me.

@filhodanuvem
Copy link
Owner

filhodanuvem commented Dec 24, 2016

Hey @Code-Hex , about the task

In order not to end with log.Fatal etc, Allow all errors of runtime to be received from runtime.Run

I fixed the problem here. The unit tests have passed but as this work is about the runtime package, I would like that you and @luizperes help me to test it manually.
Basically, each (syntax, semantical and runtime) error should not break the program on interactive mode.
Can you guys help me? After that I will merge it on develop branch.

@luizperes
Copy link
Collaborator

Hi @Code-Hex and @cloudson ! Gotcha! I will try to do my best on it!

@Code-Hex
Copy link
Contributor Author

@cloudson Nice!! Thanks for the quick work.
I will tell you when these are completed.

@Code-Hex
Copy link
Contributor Author

Code-Hex commented Dec 25, 2016

Hi @cloudson @luizperes My tasks are complete.
I've added a comment @cloudson 's task.
Thank you.

@filhodanuvem filhodanuvem merged commit 8da631f into filhodanuvem:develop Dec 28, 2016
@filhodanuvem filhodanuvem mentioned this pull request Dec 28, 2016
@filhodanuvem
Copy link
Owner

Thank you again @Code-Hex . You deserve a beer or tea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants