Adding interactive mode #38

Code-Hex · 2016-12-16T09:31:22Z

What I did?

Added interactive mode
Fixed so that it can be executed without passing it as a string argument. like gitql select hash, author, message from commits

Code-Hex · 2016-12-16T09:33:30Z

I creating functions such as complementary functions and settings, so please do not merge yet.

luizperes · 2016-12-16T20:43:04Z

Good job! I will check it @Code-Hex

luizperes · 2016-12-19T06:31:13Z

Hi @Code-Hex, please check the PR I sent to you: Code-Hex#1 in order to fix your conflicts and add the latest features.

By the way, I checked your files and they are working properly. :) However, we will need to solve the conflicts first

Fixing Conflicts for accepting filhodanuvem#14 and filhodanuvem#38

Code-Hex · 2016-12-19T13:47:34Z

@luizperes Thanks for the conflict was fixed.

luizperes · 2016-12-19T17:33:04Z

No problem! :) I've already checked and it seems to be working properly, I'm just waiting now for @cloudson review and approval! Thanks @Code-Hex.

Ah, before I forget, I think that we should discuss the number of project dependencies, because as far as I know this PR includes 3 new ones, right?

filhodanuvem · 2016-12-19T20:54:25Z

Incredible job @Code-Hex 👏 🎆 🤘
The feature is working perfectly, I'm just worried with some points:

As @luizperes said, you put new libraries into the project. Beyond chzyer/readline is the other one indispensable for you? Our installation is not already too fast so we need of the minimal number of dependencies as possible (we need to remove packages like go-clitable soon)
I saw a little difference on the flags usage
On the master gitql -type works but after this change it doesn't (gitql --type works).
I liked this change, long flags should to have two dashes (-) but I think that it could to be in a separated commit/PR, it can break someone using the flag and micro changes make our life more calm 😆
What do you guys think?

Code-Hex · 2016-12-20T13:12:53Z

@cloudson Thank you very much!!

As @luizperes said, you put new libraries into the project. Beyond chzyer/readline is the other one indispensable for you? Our installation is not already too fast so we need of the minimal number of dependencies as possible (we need to remove packages like go-clitable soon)

I understand the desire to make your installation faster.
I believe that you want to speed up the installation for binary distribution.
For me, Rather than using go get, cross compiling will be done and binaries will be distributed. like this.
I thought that it would be better for you to think about installing go get for developers.

I think that it could to be in a separated commit/PR, it can break someone using the flag and micro changes make our life more calm 😆

That's good! Rather I should have done so 😓

luizperes · 2016-12-21T19:43:45Z

Hi, I believe that I was the one who included the --type flag to this PR, my bad @Code-Hex and @cloudson

Code-Hex · 2016-12-23T16:35:09Z

@cloudson @luizperes I'm sorry and I was late because I was busy.
It was completed for the time being. However, because we are terminating the program around runtime, we often forcibly terminate during interactive mode.
But it should be fixed with another Pull Request or Branch 👍

Code-Hex · 2016-12-24T07:15:52Z

Since the completion function was not enough, I committed it again.
Please code review them. Thank you 😄

filhodanuvem · 2016-12-24T14:10:24Z

autocomplete.go

+
+func suggestTokensFromInputting(focus []rune, pos int) [][]rune {
+	return suggestInputting(focus, pos, [][]rune{
+		[]rune("select"),


We need to declare the reserved words as constants on lexical package to use these there and here.
This pull request is too big already so please, let us work in another PR.

filhodanuvem · 2016-12-24T14:18:31Z

autocomplete.go

+			// gitql> select * from commits where committer = "K" order by com[tab
+			// gitql> select * from commits where committer = "K" or com[tab
+			// In the case is inputting column inputted after "where", "by", "and", "or"
+			return suggestColumnsFromInputting(focus, pos)


I tried to type
select message from commits where tab or
select mesage from commits where date > '2017-01-01 and tab

And I saw the suggestions for reserved word instead of columns. It would be nice put unit tests for the functions, I can help you.

filhodanuvem · 2016-12-24T14:35:47Z

@Code-Hex I'm really impressived with your work here. Thank you again.
This pull request itself was really big and it was causing worries for me, so I've merged all the changes before the autocomplete commit (by the way, it is an awesome improvement).
Can you please make a rebase on your develop branch and make a new pull request just about autocomplete stuffs? I hope help you to write some unit tests on there.

Code-Hex · 2016-12-24T14:55:40Z

@cloudson OK!
Thank you for merge!!

Code-Hex added 3 commits December 16, 2016 17:22

Fixed to be able to execute query even if it is not string

1fc3ee0

Added interactive mode

c834d1f

gofmt

7f4dc13

Code-Hex mentioned this pull request Dec 16, 2016

interactive mode #14

Closed

Fixing conflicts and making it compliant with new version

9883b62

luizperes mentioned this pull request Dec 19, 2016

Fixing Conflicts for accepting #14 and #38 Code-Hex/gitql#1

Merged

Code-Hex added 2 commits December 19, 2016 22:45

Merge branch 'develop' into Code-Hex-develop

cfcd5f5

Merge pull request #1 from luizperes/Code-Hex-develop

351e366

Fixing Conflicts for accepting filhodanuvem#14 and filhodanuvem#38

Code-Hex added 3 commits December 23, 2016 23:47

Added autocomplete.go

8cae6ea

Added autocomplete for table

d1e9d78

Added autocomplete for tokens

086131f

Added autocomplete if after inputted "where", "and", "or", "order", "by"

a1f3429

filhodanuvem reviewed Dec 24, 2016

View reviewed changes

filhodanuvem closed this in 63cd84f Dec 24, 2016

Code-Hex mentioned this pull request Dec 24, 2016

Adding autocomplete for interactive mode #46

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding interactive mode #38

Adding interactive mode #38

Code-Hex commented Dec 16, 2016

Code-Hex commented Dec 16, 2016 •

edited

Loading

luizperes commented Dec 16, 2016

luizperes commented Dec 19, 2016 •

edited

Loading

Code-Hex commented Dec 19, 2016

luizperes commented Dec 19, 2016

filhodanuvem commented Dec 19, 2016

Code-Hex commented Dec 20, 2016

luizperes commented Dec 21, 2016

Code-Hex commented Dec 23, 2016 •

edited

Loading

Code-Hex commented Dec 24, 2016

filhodanuvem Dec 24, 2016

filhodanuvem Dec 24, 2016 •

edited

Loading

filhodanuvem commented Dec 24, 2016

Code-Hex commented Dec 24, 2016

Adding interactive mode #38

Adding interactive mode #38

Conversation

Code-Hex commented Dec 16, 2016

What I did?

Code-Hex commented Dec 16, 2016 • edited Loading

luizperes commented Dec 16, 2016

luizperes commented Dec 19, 2016 • edited Loading

Code-Hex commented Dec 19, 2016

luizperes commented Dec 19, 2016

filhodanuvem commented Dec 19, 2016

Code-Hex commented Dec 20, 2016

luizperes commented Dec 21, 2016

Code-Hex commented Dec 23, 2016 • edited Loading

Code-Hex commented Dec 24, 2016

filhodanuvem Dec 24, 2016

Choose a reason for hiding this comment

filhodanuvem Dec 24, 2016 • edited Loading

Choose a reason for hiding this comment

filhodanuvem commented Dec 24, 2016

Code-Hex commented Dec 24, 2016

Code-Hex commented Dec 16, 2016 •

edited

Loading

luizperes commented Dec 19, 2016 •

edited

Loading

Code-Hex commented Dec 23, 2016 •

edited

Loading

filhodanuvem Dec 24, 2016 •

edited

Loading