Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Prompt for credentials when connecting smb #11144

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Feature: Prompt for credentials when connecting smb #11144

merged 3 commits into from
Feb 5, 2023

Conversation

radu-cernatescu
Copy link
Contributor

@radu-cernatescu radu-cernatescu commented Feb 3, 2023 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Closes Feature: Prompt user for credentials when connecting to smb-server the first time #258
  • Typing in the toolbar or navigating from the Network folder to a SMB share which does not have cached/saved credentials, will prompt the user for a username and password, and whether or not they want to save their credentials (Screenshot 1).
  • Credentials are stored directly to Windows Credential Manager, not in the application (Screenshot 4). The application also does not need to read the saved credentials in order to access a network share.
  • Win32Errors are outputted in a dialog in the event of an error (Screenshots 2,3).

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
1.
credsDialog
2.
incorrect_pass
3.
net_err
4.
credManager

yaira2
yaira2 approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 5, 2023
@yaira2 yaira2 merged commit 721b5bd into files-community:main Feb 5, 2023
@radu-cernatescu radu-cernatescu deleted the 258-smb-dialog branch February 6, 2023 03:46
@radu-cernatescu radu-cernatescu mentioned this pull request Feb 7, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@gave92 gave92 gave92 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Prompt user for credentials when connecting to smb-server the first time
3 participants
@radu-cernatescu @gave92 @yaira2