Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 重构链服务的签名及消息推送接口 / refactor signer & push-msg api #5183

Closed
wants to merge 3 commits into from

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Aug 12, 2022

关联的Issues (Related Issues)

close #4952

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen marked this pull request as draft August 12, 2022 05:59
@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_sign_api branch from 2553288 to 1898418 Compare August 12, 2022 06:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #5183 (9361a93) into master (363a4e4) will decrease coverage by 0%.
The diff coverage is 0%.

❗ Current head 9361a93 differs from pull request most recent head ec676e7. Consider uploading reports for the commit ec676e7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #5183    +/-   ##
=======================================
- Coverage      25%     25%    -1%     
=======================================
  Files         587     592     +5     
  Lines       65184   65739   +555     
=======================================
- Hits        16619   16571    -48     
- Misses      46390   47010   +620     
+ Partials     2175    2158    -17     

@diwufeiwen diwufeiwen self-assigned this Aug 12, 2022
@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_sign_api branch from 1898418 to 78e276c Compare August 17, 2022 07:17
@diwufeiwen diwufeiwen marked this pull request as ready for review August 17, 2022 07:19
@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_sign_api branch 4 times, most recently from 5145061 to 660c34f Compare August 23, 2022 09:54
@diwufeiwen diwufeiwen requested a review from zl03jsj August 25, 2022 09:38
@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_sign_api branch 2 times, most recently from c1c66a0 to 9361a93 Compare September 9, 2022 08:48
@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_sign_api branch from 9361a93 to ec676e7 Compare September 28, 2022 03:23
@diwufeiwen
Copy link
Contributor Author

因为要在nv17升级后发版,故将其合并到分支:release/v1.9.0-pre-rc1,这个pr关闭

@diwufeiwen diwufeiwen closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[venus-market] 重构venus-market中地址和账号关系及相关组件
3 participants