-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[venus-market] 重构venus-market中地址和账号关系及相关组件 #4952
Closed
9 of 20 tasks
Labels
Comments
hunjixin
added
P1
High - we should be working on this now or in the immediate future
design
Venus feature/system design issues
V-venus-market
venus-market component
P2
Medium - we should get to this soon
and removed
P1
High - we should be working on this now or in the immediate future
labels
Jun 21, 2022
publish订单聚合方式, fundmgr资产聚合方式 聚合方式使用地址和账号 |
9 tasks
5 tasks
5 tasks
17 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #4947
Originally posted by hunjixin June 20, 2022
Checklist
latest release
, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Venus component
Venus Version
Describe the Bug
venus-market中存在两个问题
现在会从venus-auth拿出账号矿工, 建立一个addr-account的表,当需要签名是通过from查询地址属于哪个account,在通过gateway去找用户签名。
但是如果这个矿工被移除,在这个cache表中移除对应的地址将会十分困难。另外一个问题是,如果两个account使用相同的地址,这里会存在后来的addr-account覆盖前面的情况,签名转发会不正确。
在目前market的部分功能,例如publish订单,paychannel会进行对相同地址的一些信息进行聚合,在进行签名的时候就无法区分是否是数据是来源于哪个account。签名转发自然也就不正确了。
解决办法:在account级别上隔离market里面的各种信息,在account级别上进行资产的聚合支付,这样在寻求消息签名时自然可以知道该到哪个account上去寻求签名。这样也就不需要addr-account缓存的存在了。
影响部分:
Logging Information
Repo Steps
No response
The text was updated successfully, but these errors were encountered: