Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[venus-market] 重构venus-market中地址和账号关系及相关组件 #4952

Closed
9 of 20 tasks
Tracked by #4972 ...
hunjixin opened this issue Jun 21, 2022 Discussed in #4947 · 2 comments
Closed
9 of 20 tasks
Tracked by #4972 ...

[venus-market] 重构venus-market中地址和账号关系及相关组件 #4952

hunjixin opened this issue Jun 21, 2022 Discussed in #4947 · 2 comments
Assignees
Labels
P2 Medium - we should get to this soon V-venus-market venus-market component

Comments

@hunjixin
Copy link
Contributor

Discussed in #4947

Originally posted by hunjixin June 20, 2022

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the venus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the venus forum, and there is no existing related issue or discussion.
  • I am running the latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to venus.

Venus component

  • venus daemon - chain sync
  • venus auth - authentication
  • venus gateway - chain service gateway
  • venus miner - mining and block production
  • venus sealer/worker - sealing
  • venus sealer - proving(WindowPoSt)
  • venus market - storage deal
  • venus market - retrieval deal
  • venus market - data transfer
  • venus light-weight client
  • venus JSON-RPC API
  • venus messager - message management (mpool)
  • Other

Venus Version

latest

Describe the Bug

venus-market中存在两个问题

  1. 现在会从venus-auth拿出账号矿工, 建立一个addr-account的表,当需要签名是通过from查询地址属于哪个account,在通过gateway去找用户签名。
    但是如果这个矿工被移除,在这个cache表中移除对应的地址将会十分困难。另外一个问题是,如果两个account使用相同的地址,这里会存在后来的addr-account覆盖前面的情况,签名转发会不正确。

  2. 在目前market的部分功能,例如publish订单,paychannel会进行对相同地址的一些信息进行聚合,在进行签名的时候就无法区分是否是数据是来源于哪个account。签名转发自然也就不正确了。

解决办法:在account级别上隔离market里面的各种信息,在account级别上进行资产的聚合支付,这样在寻求消息签名时自然可以知道该到哪个account上去寻求签名。这样也就不需要addr-account缓存的存在了。
影响部分:

1. minermgr 删除。
2. paychannel支持按account/addr级别进行资金聚合和支付,而不是通过addr。
3. 签名客户端需要换一种抽象方法来兼容lotus节点直接签名。

Logging Information

--

Repo Steps

No response

@hunjixin hunjixin added P1 High - we should be working on this now or in the immediate future design Venus feature/system design issues V-venus-market venus-market component P2 Medium - we should get to this soon and removed P1 High - we should be working on this now or in the immediate future labels Jun 21, 2022
@diwufeiwen diwufeiwen mentioned this issue Jun 27, 2022
40 tasks
@diwufeiwen diwufeiwen mentioned this issue Jul 25, 2022
36 tasks
@diwufeiwen diwufeiwen self-assigned this Aug 1, 2022
@diwufeiwen diwufeiwen moved this to In Progress in Venus Project Aug 2, 2022
@diwufeiwen
Copy link
Contributor

publish订单聚合方式, fundmgr资产聚合方式 聚合方式使用地址和账号

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium - we should get to this soon V-venus-market venus-market component
Projects
Archived in project
2 participants