You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sudo-shashank
changed the title
fix(gateway): handle missing filters in EthGetFilterLogs
fix(gateway): handle filter not found in EthGetFilterLogs
Feb 17, 2026
sudo-shashank
changed the title
fix(gateway): handle filter not found in EthGetFilterLogs
fix(gateway): return ErrFilterNotFound in EthGetFilterLogs V1/V2 proxy
Feb 17, 2026
sudo-shashank
changed the title
fix(gateway): return ErrFilterNotFound in EthGetFilterLogs V1/V2 proxy
fix(gateway): return ErrFilterNotFound in EthGetFilterLogs V1 and V2 proxies
Feb 17, 2026
@sudo-shashank have you tried running this and does it get you the results you want? I haven't looked widely and am not sure if error code matters here at all but quicknode's example runner gives me:
@sudo-shashank have you tried running this and does it get you the results you want? I haven't looked widely and am not sure if error code matters here at all but quicknode's example runner gives me:
@rvagg via lotus gateway we don't get filter not found error message if filter id is not found for Filecoin.EthGetFilterLogs, it currently returns nil.
This error is expected and return correctly only for Filecoin.EthGetFilterChanges as implemented here
rvagg
changed the title
fix(gateway): return ErrFilterNotFound in EthGetFilterLogs V1 and V2 proxies
fix(gateway): return error instead of nil for unknown filter in EthGetFilterLogs
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
ChainSafe/forest#6580
Proposed Changes
ErrFilterNotFoundinstead ofnilwhen filter not found inEthGetFilterLogsfor both v1 and v2 gateway proxies.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: