Skip to content

lotus-gateway: Unfilter Filecoin.EthGetFilterLogs #6620

Merged
sudo-shashank merged 3 commits intomainfrom
shashank/fix-eth_getFilterLogs
Mar 31, 2026
Merged

lotus-gateway: Unfilter Filecoin.EthGetFilterLogs #6620
sudo-shashank merged 3 commits intomainfrom
shashank/fix-eth_getFilterLogs

Conversation

@sudo-shashank
Copy link
Copy Markdown
Contributor

@sudo-shashank sudo-shashank commented Feb 17, 2026

Summary of changes

Changes introduced in this pull request:

  • Unfilter Filecoin.EthGetFilterLogs check with gateway as it's resolved in lotus release v1.35.1.

Reference issue to close (if applicable)

Closes #6580

Other information and links

filecoin-project/lotus#13519

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Updated test configuration to reflect that an API method is no longer marked as unsupported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0f4618cd-8373-4dd5-b6f8-eb4c6a464c2d

📥 Commits

Reviewing files that changed from the base of the PR and between d52a294 and f2256ee.

📒 Files selected for processing (1)
  • scripts/tests/api_compare/filter-list-gateway
💤 Files with no reviewable changes (1)
  • scripts/tests/api_compare/filter-list-gateway

Walkthrough

This pull request removes Filecoin.EthGetFilterLogs from the "broken" methods list in the lotus-gateway API comparison filter configuration, reflecting that this RPC method has been fixed and is now functional with the gateway.

Changes

Cohort / File(s) Summary
Gateway Filter Configuration
scripts/tests/api_compare/filter-list-gateway
Removed !Filecoin.EthGetFilterLogs from the broken methods section, indicating the method is no longer marked as unsupported.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • akaladarshi
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the filter on Filecoin.EthGetFilterLogs for lotus-gateway, which aligns with the code change and PR objectives.
Linked Issues check ✅ Passed The PR successfully addresses issue #6580 by removing Filecoin.EthGetFilterLogs from the gateway filter list, reflecting the fix in lotus v1.35.1 as intended.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to removing one filter entry from the gateway test configuration, directly addressing the linked issue with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shashank/fix-eth_getFilterLogs
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch shashank/fix-eth_getFilterLogs

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank added the RPC requires calibnet RPC checks to run on CI label Feb 17, 2026
@sudo-shashank sudo-shashank changed the title lotus-gateway: Fix Filecoin.EthGetFilterLogs lotus-gateway: Unfilter Filecoin.EthGetFilterLogs Mar 2, 2026
@sudo-shashank sudo-shashank force-pushed the shashank/fix-eth_getFilterLogs branch from 5fd19ee to 1248f27 Compare March 12, 2026 01:48
@sudo-shashank sudo-shashank marked this pull request as ready for review March 31, 2026 09:14
@sudo-shashank sudo-shashank requested a review from a team as a code owner March 31, 2026 09:14
@sudo-shashank sudo-shashank requested review from akaladarshi and hanabi1224 and removed request for a team March 31, 2026 09:14
@sudo-shashank sudo-shashank enabled auto-merge March 31, 2026 09:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.89%. Comparing base (d52a294) to head (f2256ee).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52a294...f2256ee. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo-shashank sudo-shashank added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit e075a77 Mar 31, 2026
40 checks passed
@sudo-shashank sudo-shashank deleted the shashank/fix-eth_getFilterLogs branch March 31, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lotus-gateway: Fix Filecoin.EthGetFilterLogs

2 participants