fix(cli): add deposit-margin-factor to lotus miner init command#13407
Merged
rjan90 merged 4 commits intofilecoin-project:masterfrom Oct 30, 2025
Merged
fix(cli): add deposit-margin-factor to lotus miner init command#13407rjan90 merged 4 commits intofilecoin-project:masterfrom
deposit-margin-factor to lotus miner init command#13407rjan90 merged 4 commits intofilecoin-project:masterfrom
Conversation
Contributor
Author
|
Manually tested and passed on cali: https://calibration.filfox.info/zh/message/bafy2bzacebopk3otbburekcheu5nepxdgnpzcstew6q3pxbko6solrphwryde?t=4 |
Contributor
Author
|
cc @rjan90 |
rvagg
reviewed
Oct 30, 2025
Member
|
sgtm |
Co-authored-by: Rod Vagg <rod@vagg.org>
rjan90
approved these changes
Oct 30, 2025
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
aceppaluni
pushed a commit
to aceppaluni/lotus
that referenced
this pull request
Dec 2, 2025
…ilecoin-project#13407) * fix(cli): add to lotus-miner init * chore: make docsgen-cli * chore: update CHANGELOG.md * chore: improve error message Co-authored-by: Rod Vagg <rod@vagg.org> --------- Co-authored-by: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#13365
Proposed Changes
Unify the behavior of lotus-miner init and lotus-shed miner create. Add deposit-margin-factor to amplify the simulated deposit and cover network fluctuations. The amplification factor is set to 1.01 by default.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: