fix(cli): add deposit-margin-factor to the new miner commands#13365
Merged
rjan90 merged 1 commit intofilecoin-project:masterfrom Sep 26, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
0x5459
changed the title
deposit-margin-factor to the new miner commandsdeposit-margin-factor to the new miner commands
github-actions
Bot
dismissed
their stale review
PR title now matches the required format.
0x5459
force-pushed
the
fix/add-deposit-margin-factor-to-new-miner-cmd
branch
from
52868cd to
2e49213
Compare
…miners that fail due to insufficient deposit
0x5459
force-pushed
the
fix/add-deposit-margin-factor-to-new-miner-cmd
branch
from
2e49213 to
2609ecf
Compare
tediou5
approved these changes
Sep 26, 2025
Contributor
tediou5
left a comment
tediou5
left a comment
There was a problem hiding this comment.
look good to me, thanks for your pr.
Currently, the mainnet requires approximately 4.4 fil. By default, an additional 0.04 fil will be sent to the miner. This amount is not locked up and can be used by users to pay daily fees. I think this is completely acceptable.
github-project-automation
Bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
fix #13364
Proposed Changes
Add a
deposit-margin-factoroption tolotus-miner actor newandlotus-shed miner createto ensure the sent deposit still covers the on-chain requirement (even if it rises between lookup and execution), preventing miner creation from failing due to insufficient deposit.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: