fix: use single quotes in GOFLAGS ldflags to match network targets#13330
Merged
fix: use single quotes in GOFLAGS ldflags to match network targets#13330
Conversation
fix: use single quotes in GOFLAGS ldflags to match network targets
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a quote nesting issue in the Makefile where inconsistent quote usage between base GOFLAGS definition and network-specific targets caused build failures.
- Changes double quotes to single quotes around
$(ldflags)in the base GOFLAGS definition - Ensures consistency with network-specific targets that already use single quotes
- Resolves make command failures when LDFLAGS is set
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rvagg
approved these changes
Sep 10, 2025
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
oh, odd
can you confirm make lotus still works with that since it uses unquoted GOFLAGS
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
Contributor
Author
Can confirm that |
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes quote nesting issue introduced by PR #13328.
Proposed Changes
PR #13328 changed network-specific targets to use single quotes around GOFLAGS assignments, but the base GOFLAGS definition still used double quotes around $(ldflags), causing quote nesting when LDFLAGS is set, and failure to run the make commands.