fix: resolve quote nesting in network-specific build targets#13328
Merged
rvagg merged 1 commit intofilecoin-project:masterfrom Sep 9, 2025
Merged
fix: resolve quote nesting in network-specific build targets#13328rvagg merged 1 commit intofilecoin-project:masterfrom
rvagg merged 1 commit intofilecoin-project:masterfrom
Conversation
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes quote nesting bug in network-specific build targets when LDFLAGS is set.
Commands like
LDFLAGS=-L/usr/local/cuda/lib64 make calibnet-lotusfailed due to nested double quotes in GOFLAGS construction:GOFLAGS+=-ldflags="$(ldflags)"+GOFLAGS="$(GOFLAGS) $(FLAGS)"GOFLAGS="-ldflags="..." -tags=calibnet"(parsing error)Changed to single quotes to avoid nesting.