ci: update curl in the release workflow#13223
Merged
rjan90 merged 3 commits intophi/prep-v1331-rc1from Jul 21, 2025
Merged
Conversation
galargh
added
the
skip/changelog
galargh
commented
Jul 19, 2025
galargh
commented
Jul 19, 2025
rvagg
approved these changes
Jul 21, 2025
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
rjan90
pushed a commit
that referenced
this pull request
Jul 21, 2025
* ci: update curl in the release workflow * Update .github/workflows/release.yml * Update .github/workflows/release.yml
rjan90
pushed a commit
that referenced
this pull request
Jul 21, 2025
* ci: update curl in the release workflow * Update .github/workflows/release.yml * Update .github/workflows/release.yml
rjan90
pushed a commit
that referenced
this pull request
Jul 21, 2025
* ci: update curl in the release workflow * Update .github/workflows/release.yml * Update .github/workflows/release.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issues we've seen with the release workflow - https://github.com/filecoin-project/lotus/actions/runs/16368564857
macos-13started usingcurl@8.14.1, which seems to have issues with setting the correct exit codes. What happens now onmacos-13is:What happens on
macos-14, which uses an earlier version of curl:The root cause of these issues is the faulty way in which we try to download the release assets. To fix that, we'll have to update https://github.com/filecoin-project/filecoin-ffi/blob/master/install-filcrypto#L79. However, I do need a little more time to figure out how to update it correctly.
In the meantime, as a quick fix, this PR proposes to upgrade curl to a version (8.15.0) that correctly exits when the download fails, which means, for now, we'll always fall back to building filecoin-ffi from source during the release.