chore: pass accept header to asset download request#534
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an Accept header to asset download requests to ensure proper binary asset retrieval from GitHub releases. The change prevents fallback to building assets from source by ensuring the download request explicitly requests binary content.
- Adds
Accept:application/octet-streamheader to curl command for downloading release assets
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
BigLep
approved these changes
Jul 21, 2025
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
rjan90
approved these changes
Jul 21, 2025
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to filecoin-project/lotus#13223
It passes
Accept:application/octet-streamheader in a request which downloads the release assets. This will ensure we can actually download the assets instead of having to build them from source every time.