Skip to content

feat: changing the order of inspectMiner could improve efficiency #13206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvagg merged 2 commits into from
Jul 10, 2025
Merged

feat: changing the order of inspectMiner could improve efficiency #13206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb66bb
feat: changing the order of inspectMiner could improve efficiency
Terryhung Jul 8, 2025
a19d578
fix: wrong inpurt for inspectMiner
Terryhung Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions cmd/lotus-shed/miner-fees.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,21 +563,30 @@ var minerFeesInspect = &cli.Command{
}
cronParams = &p

fee, penalty, err := inspectMiner(trace.Msg.To)
if err != nil {
return xerrors.Errorf("inspecting miner: %w", err)
}
thisExecCronMiner = &minerBurn{
addr: trace.Msg.To,
burn: big.Zero(),
fee: fee,
penalty: penalty,
fee: big.Zero(),
penalty: big.Zero(),
}
burns = append(burns, thisExecCronMiner)
cronMinerCalls[trace.Msg.To] = struct{}{}
} else if thisExecCronMiner != nil && trace.Msg.From == thisExecCronMiner.addr && trace.Msg.To == burnAddr {
// TODO: handle multiple burn? Shouldn't happen but maybe it should be checked?
thisExecCronMiner.burn = trace.Msg.Value

// If we have a burn, we can inspect the miner for fees and penalties.
if thisExecCronMiner.burn.IsZero() {
return nil
}

fee, penalty, err := inspectMiner(trace.Msg.From)
if err != nil {
return xerrors.Errorf("inspecting miner: %w", err)
}

thisExecCronMiner.fee = fee
thisExecCronMiner.penalty = penalty
}

for _, st := range trace.Subcalls {
Expand Down