feat: changing the order of inspectMiner could improve efficiency#13206
Merged
rvagg merged 2 commits intofilecoin-project:masterfrom Jul 10, 2025
Merged
Conversation
Terryhung
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
Terryhung
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
rvagg
reviewed
Jul 9, 2025
rjan90
dismissed
github-actions[bot]’s stale review
PR title now matches the required format.
rvagg
approved these changes
Jul 10, 2025
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Since inspectMiner needs to load the Miner, MinerState, Deadline, and DeadlineInfo, it’s quite time-consuming. So we should only call inspectMiner if we’re certain there will be a fee or penalty.
Proposed Changes
Ｃhanging the order of inspectMiner could improve efficiency.
Additional Info
[skip changelog]
Checklist
Before you mark the PR ready for review, please make sure that: