Skip to content

chore(shed): update trace-finding in lotus-shed miner fees & fees-inspect with a better top-down filter #13204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjan90 merged 3 commits into from
Jul 8, 2025
Merged

chore(shed): update trace-finding in lotus-shed miner fees & fees-inspect with a better top-down filter #13204

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d6b7d7
Initial plan
Copilot Jul 8, 2025
55d7988
Implement top-down trace filtering for lotus-shed miner fees commands
Copilot Jul 8, 2025
7923307
Refactor trace filtering to use early returns instead of validTrace v…
Copilot Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions cmd/lotus-shed/miner-fees.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,25 @@ var minerFeesCmd = &cli.Command{
params := ""
var has bool

// Implement top-down filtering based on expected cron execution flow
switch depth {
case 0:
// At depth 0: SystemActorAddr (f00) -> CronActorAddr (f03) method 2 (EpochTick)
if !(trace.Msg.From == builtin.SystemActorAddr && trace.Msg.To == builtin.CronActorAddr && trace.Msg.Method == 2) {
return "", false, nil
}
case 1:
// At depth 1: CronActorAddr (f03) -> StoragePowerActorAddr (f04) method 5 (OnEpochTickEnd)
if !(trace.Msg.From == builtin.CronActorAddr && trace.Msg.To == power.Address && trace.Msg.Method == 5) {
return "", false, nil
}
case 2:
// At depth 2: StoragePowerActorAddr (f04) -> miner actors method 12 (OnDeferredCronEvent)
if !(trace.Msg.From == power.Address && trace.Msg.Method == 12) {
return "", false, nil
}
}

if trace.Msg.From == minerAddr || trace.Msg.To == minerAddr {
has = true // involves our miner

Expand Down Expand Up @@ -511,6 +530,25 @@ var minerFeesInspect = &cli.Command{
cronMinerCalls := make(map[address.Address]struct{})
var traceBurns func(depth int, trace types.ExecutionTrace, thisExecCronMiner *minerBurn) error
traceBurns = func(depth int, trace types.ExecutionTrace, thisExecCronMiner *minerBurn) error {
// Implement top-down filtering based on expected cron execution flow
switch depth {
case 0:
// At depth 0: SystemActorAddr (f00) -> CronActorAddr (f03) method 2 (EpochTick)
if !(trace.Msg.From == builtin.SystemActorAddr && trace.Msg.To == builtin.CronActorAddr && trace.Msg.Method == 2) {
return nil
}
case 1:
// At depth 1: CronActorAddr (f03) -> StoragePowerActorAddr (f04) method 5 (OnEpochTickEnd)
if !(trace.Msg.From == builtin.CronActorAddr && trace.Msg.To == power.Address && trace.Msg.Method == 5) {
return nil
}
case 2:
// At depth 2: StoragePowerActorAddr (f04) -> miner actors method 12 (OnDeferredCronEvent)
if !(trace.Msg.From == power.Address && trace.Msg.Method == 12) {
return nil
}
}

if trace.Msg.From == power.Address && trace.Msg.Method == 12 {
// cron call to miner
if thisExecCronMiner != nil {
Expand Down
Loading