chore(shed): update trace-finding in lotus-shed miner fees & fees-inspect with a better top-down filter#13204
Merged
chore(shed): update trace-finding in lotus-shed miner fees & fees-inspect with a better top-down filter#13204
Conversation
Co-authored-by: rvagg <495647+rvagg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update trace-finding in lotus-shed miner fees & fees-inspect with a better top-down filter
Update trace-finding in lotus-shed miner fees & fees-inspect with a better top-down filter
Jul 8, 2025
rvagg
reviewed
Jul 8, 2025
…ariable Co-authored-by: rvagg <495647+rvagg@users.noreply.github.com>
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
PR title now matches the required format.
rvagg
approved these changes
Jul 8, 2025
rjan90
approved these changes
Jul 8, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a better top-down filtering approach for trace-finding in the
lotus-shed miner feesandlotus-shed miner fees-inspectcommands, as requested in the issue.Problem
Previously, both commands used a bottom-up filtering approach that would trace any execution involving the target miner address. This resulted in noisy output with many irrelevant traces that didn't follow the actual cron execution flow.
Solution
The new implementation adds hierarchical trace filtering that follows the expected cron execution flow:
This matches the actual protocol flow described in the issue:
Changes Made
printExecfunction in thefeescommand with depth-based filtering logictraceBurnsfunction in thefees-inspectcommand with the same filtering approachBenefits
Testing
Fixes #13203.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/filecoin-project/filecoin-ffi/releases/tags/v1.33.1-devcurl --retry 3 --location REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.