Skip to content

ci: update PR title validation to accept revert titles and move skip changelog to description#13166

Merged
BigLep merged 3 commits intomasterfrom
biglep/fixup-title-and-changelog-checks
Jun 9, 2025
Merged

ci: update PR title validation to accept revert titles and move skip changelog to description#13166
BigLep merged 3 commits intomasterfrom
biglep/fixup-title-and-changelog-checks

Conversation

@BigLep
Copy link
Member

@BigLep BigLep commented Jun 9, 2025

Summary

  • Accept "Revert ..." titles from GitHub's revert functionality in pr-title-check.yml
  • Remove [skip changelog] prefix support from PR titles
  • Update changelog.yml to check for [skip changelog] in PR description instead of title
  • Update CONTRIBUTING.md to document both changes

Test plan

  • Test PR with "Revert ..." title (should pass validation)
  • Test PR with "[skip changelog]" in title (should fail validation)
  • Test PR with "[skip changelog]" in description (should skip changelog requirement)
  • Verify CONTRIBUTING.md documentation matches enforcement logic

Additional notes

BigLep and others added 2 commits June 9, 2025 09:30
…changelog to description

- Accept "Revert ..." titles from GitHub's revert functionality in pr-title-check.yml
- Remove [skip changelog] prefix support from PR titles
- Update changelog.yml to check for [skip changelog] in PR description instead of title
- Update CONTRIBUTING.md to document both changes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jun 9, 2025
@BigLep BigLep requested a review from rjan90 June 9, 2025 16:47
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Jun 9, 2025
@BigLep BigLep self-assigned this Jun 9, 2025
@BigLep BigLep marked this pull request as ready for review June 9, 2025 16:47
Copilot AI review requested due to automatic review settings June 9, 2025 16:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the PR title validation to accept GitHub revert titles and moves the “[skip changelog]” check from the title to the PR description. Key changes include:

  • Updating the regex in pr-title-check.yml to accept “Revert ..." titles and remove the “[skip changelog]” prefix support from PR titles.
  • Modifying changelog.yml to look for “[skip changelog]” in the PR description instead.
  • Updating CONTRIBUTING.md and related workflow documents to reflect these changes.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CONTRIBUTING.md Updated documentation for title conventions and changelog management instructions.
.github/workflows/pr-title-check.yml Updated title validation regex to support GitHub revert titles and remove skip changelog support.
.github/workflows/changelog.yml Changed condition to check the PR description for “[skip changelog]” instead of the title.
.github/workflows/CLAUDE.md Added reference to AGENTS.md.
.github/workflows/AGENTS.md Added documentation for validation workflows with a minor markdown syntax issue.
Comments suppressed due to low confidence (1)

.github/workflows/AGENTS.md:6

  • There appears to be an extra closing bracket in the markdown link. Please remove the stray ']' after CONTRIBUTING.md to ensure correct formatting.
- **CRITICAL**: Changes to validation logic MUST be reflected in CONTRIBUTING.md](../../CONTRIBUTING.md).  CONTRIBUTING.md and enforcement workflows should be kept in sync.

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Jun 9, 2025
@BigLep BigLep merged commit 77a793c into master Jun 9, 2025
100 checks passed
@BigLep BigLep deleted the biglep/fixup-title-and-changelog-checks branch June 9, 2025 17:32
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants