Skip to content

Revert "feat(ci): only markdown action to skip some CI workflows"#13164

Merged
BigLep merged 1 commit intomasterfrom
revert-13118-kamui/only-markdown-lint
Jun 9, 2025
Merged

Revert "feat(ci): only markdown action to skip some CI workflows"#13164
BigLep merged 1 commit intomasterfrom
revert-13118-kamui/only-markdown-lint

Conversation

@BigLep
Copy link
Copy Markdown
Member

@BigLep BigLep commented Jun 9, 2025

Reverts #13118

Reasons are discussed in #13069

Copilot AI review requested due to automatic review settings June 9, 2025 14:53
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jun 9, 2025
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Jun 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the changes introduced in #13118 by removing the markdown-only change detection logic from the CI workflows. The key changes include the removal of the "planner" jobs and associated dependency conditions across multiple workflow files, as well as the removal of the only-markdown action definition.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/stale.yml Removed the "planner" job and its dependency from the stale workflow.
.github/workflows/docker.yml Removed the "planner" job and its dependency from the docker workflow.
.github/workflows/check.yml Removed the "planner" job and its dependency from several check jobs.
.github/workflows/build.yml Removed the "planner" job and its dependency from the build workflow.
.github/actions/only-markdown/action.yml Removed the only-markdown action file as part of reverting the markdown-only logic.
Comments suppressed due to low confidence (5)

.github/workflows/stale.yml:14

  • The removal of the 'needs: planner' dependency in the stale workflow aligns with the reversion decision. Verify that this change doesn't break any downstream workflow expectations.
   -    needs: planner

.github/workflows/docker.yml:30

  • Removing the 'needs: planner' dependency in the Docker workflow is consistent with the overall reversion of markdown-only change logic. Double-check that this removal does not affect the conditional execution of subsequent jobs.
   -    needs: planner

.github/workflows/check.yml:24

  • Multiple instances of 'needs: planner' have been removed from the check workflows. Ensure that the removal of these dependencies does not inadvertently disable necessary job sequencing in your CI pipeline.
   -    needs: planner

.github/workflows/build.yml:23

  • The build workflow no longer depends on the 'planner' job after reverting the markdown-only change logic. Confirm that this change preserves the intended build process without unintended side effects.
   -    needs: planner

.github/actions/only-markdown/action.yml:1

  • The removal of the only-markdown action file is in line with the reversion of markdown-only CI behavior. Verify that no external workflow references depend on this action.
-name: Only Markdown Changed

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigLep BigLep dismissed github-actions[bot]’s stale review June 9, 2025 17:35

I am just working on reverting this previous bad PR and #13166 will allow these titles in the future

@BigLep BigLep disabled auto-merge June 9, 2025 17:35
@BigLep BigLep requested a review from rjan90 June 9, 2025 17:36
@github-project-automation github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Jun 9, 2025
@BigLep BigLep merged commit 4526979 into master Jun 9, 2025
95 of 96 checks passed
@BigLep BigLep deleted the revert-13118-kamui/only-markdown-lint branch June 9, 2025 19:33
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants