Revert "feat(ci): only markdown action to skip some CI workflows"#13164
Revert "feat(ci): only markdown action to skip some CI workflows"#13164
Conversation
)" This reverts commit e53768c.
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes introduced in #13118 by removing the markdown-only change detection logic from the CI workflows. The key changes include the removal of the "planner" jobs and associated dependency conditions across multiple workflow files, as well as the removal of the only-markdown action definition.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/stale.yml | Removed the "planner" job and its dependency from the stale workflow. |
| .github/workflows/docker.yml | Removed the "planner" job and its dependency from the docker workflow. |
| .github/workflows/check.yml | Removed the "planner" job and its dependency from several check jobs. |
| .github/workflows/build.yml | Removed the "planner" job and its dependency from the build workflow. |
| .github/actions/only-markdown/action.yml | Removed the only-markdown action file as part of reverting the markdown-only logic. |
Comments suppressed due to low confidence (5)
.github/workflows/stale.yml:14
- The removal of the 'needs: planner' dependency in the stale workflow aligns with the reversion decision. Verify that this change doesn't break any downstream workflow expectations.
- needs: planner
.github/workflows/docker.yml:30
- Removing the 'needs: planner' dependency in the Docker workflow is consistent with the overall reversion of markdown-only change logic. Double-check that this removal does not affect the conditional execution of subsequent jobs.
- needs: planner
.github/workflows/check.yml:24
- Multiple instances of 'needs: planner' have been removed from the check workflows. Ensure that the removal of these dependencies does not inadvertently disable necessary job sequencing in your CI pipeline.
- needs: planner
.github/workflows/build.yml:23
- The build workflow no longer depends on the 'planner' job after reverting the markdown-only change logic. Confirm that this change preserves the intended build process without unintended side effects.
- needs: planner
.github/actions/only-markdown/action.yml:1
- The removal of the only-markdown action file is in line with the reversion of markdown-only CI behavior. Verify that no external workflow references depend on this action.
-name: Only Markdown Changed
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
I am just working on reverting this previous bad PR and #13166 will allow these titles in the future
Reverts #13118
Reasons are discussed in #13069