Skip to content

chore: return method not supported via Gateway when /v2 is absent #13121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masih merged 2 commits into from
May 11, 2025
Merged

chore: return method not supported via Gateway when /v2 is absent #13121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e1800
Return `method not supported` via Gateway when /v2 is absent
masih May 10, 2025
f3d0371
Address review comment and update changelog
masih May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- fix(f3): limit the concurrency of F3 power table calculation ([filecoin-project/lotus#13085](https://github.com/filecoin-project/lotus/pull/13085))
- feat(f3): remove dynnamic manifest functionality and use static manifest ([filecoin-project/lotus#13074](https://github.com/filecoin-project/lotus/pull/13074))
- chore(deps): bump filecoin-ffi for fvm@v4.7 which adds Logs and IpldOps to debug FVM execution traces ([filecoin-project/lotus#13029](https://github.com/filecoin-project/lotus/pull/13029))
- chore: return `method not supported` via Gateway when /v2 isn't supported by the backend ([filecoin-project/lotus#13121](https://github.com/filecoin-project/lotus/pull/13121)

See https://github.com/filecoin-project/lotus/blob/release/v1.33.0/CHANGELOG.md

Expand Down
7 changes: 4 additions & 3 deletions cli/lotus/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,11 @@ var DaemonCmd = &cli.Command{

gapiv2, closerV2, err := lcli.GetGatewayAPIV2(cctx)
if err != nil {
return err
log.Warnw("Unable to connect to v2 API. Using method not supported for /rpc/v2 in gateway", "err", err)
gapiv2 = &v2api.GatewayStruct{ /* Returns "method not supported" for everything */ }
} else {
defer closerV2()
}
defer closerV2()

liteModeDeps = node.Options(
node.Override(new(lapi.Gateway), gapiv1),
node.Override(new(v2api.Gateway), gapiv2))
Expand Down