chore: return method not supported via Gateway when /v2 is absent#13121
Merged
chore: return method not supported via Gateway when /v2 is absent#13121
method not supported via Gateway when /v2 is absent#13121Conversation
When there is no /v2 api offered by the full-node gracefully fallback to returning `method not supported` via Gateway.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
masih
changed the title
method not supported via Gateway when /v2 is absentmethod not supported via Gateway when /v2 is absent
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
rvagg
reviewed
May 11, 2025
rvagg
approved these changes
May 11, 2025
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
tested, works well, just needs the log fix and maybe this should also get a CHANGELOG entry so we can ship a release that may have only this fix (can have more, but if we did just this change then it should say something)
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
masih
removed
the
skip/changelog
rvagg
approved these changes
May 11, 2025
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is no /v2 api offered by the full-node gracefully fallback to returning
method not supportedvia Gateway.Fixes #13119