Skip to content

feat: integrate & test FIP-0098 additions#12968

Merged
rvagg merged 1 commit intomasterfrom
rvagg/fip-0098
Mar 21, 2025
Merged

feat: integrate & test FIP-0098 additions#12968
rvagg merged 1 commit intomasterfrom
rvagg/fip-0098

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Mar 20, 2025

Ref: filecoin-project/go-state-types#376
Ref: filecoin-project/builtin-actors#1639

I've added some extras in our state types abstractions here, I'd like to add more and reduce (ideally remove) the direct uses of go-state-types versioned actor types we have through the codebase. (See #12960 for some of how annoying this is). My goal in the itest was to not refer to go-state-types at all while testing all of those additions. We should be able to approach almost all other uses of those types throughout the code in the same way, but we're pretty sloppy.

Also removed some batch balancer stuff.

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Mar 20, 2025
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Mar 20, 2025
@rjan90 rjan90 linked an issue Mar 20, 2025 that may be closed by this pull request
@BigLep BigLep moved this from 🐱 Todo to 🔎 Awaiting Review in nv25 Track Board Mar 20, 2025
@BigLep BigLep requested a review from ZenGround0 March 20, 2025 20:02
@BigLep
Copy link
Copy Markdown
Member

BigLep commented Mar 20, 2025

Requested review from @ZenGround0 given he gave approval on filecoin-project/builtin-actors#1639, but @ZenGround0 , if you can't look this week, please request @Stebalien instead.

@BigLep
Copy link
Copy Markdown
Member

BigLep commented Mar 20, 2025

@rvagg : I assume this should be backported?

@rjan90 : would you ideally want to get this merged before the calibnet upgrade so migration pathways are flexed with this code? (I assume we'd just encourage a few calibnodes to use master with this change rather than cutting another RC at this point.)

@rjan90
Copy link
Copy Markdown
Contributor

rjan90 commented Mar 20, 2025

would you ideally want to get this merged before the calibnet upgrade so migration pathways are flexed with this code? (I assume we'd just encourage a few calibnodes to use master with this change rather than cutting another RC at this point.)

Yes, I think running either this branch / or master with the changes merged during the Calibnet upgrade will give us enough confidence to have this backported to the release/v1.32.0 branch

Copy link
Copy Markdown
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise this looks correct.

Comment thread chain/actors/builtin/miner/actor.go.template Outdated
Comment thread chain/actors/builtin/miner/actor.go.template Outdated
@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Mar 20, 2025
@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Mar 21, 2025

I also added a miner.PledgePenaltyForTermination utility wrapper for the v16 implementation while I was in there, but this one will error for everything prior to v16 since that's the simplified one we introduced.

Comment thread chain/actors/builtin/miner/actor.go.template Outdated
@rvagg rvagg merged commit a8ed5ba into master Mar 21, 2025
91 checks passed
@rvagg rvagg deleted the rvagg/fip-0098 branch March 21, 2025 01:50
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 21, 2025
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting Review to 🎉 Done in nv25 Track Board Mar 21, 2025
@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Mar 21, 2025

I shouldn't have merged this without a new go-state-types, I'll get that updated now in a new PR

rvagg added a commit that referenced this pull request Mar 21, 2025
rvagg added a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

FIP-0098 integration

4 participants