Conversation
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 20, 2025
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 20, 2025
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 20, 2025
Member
|
Requested review from @ZenGround0 given he gave approval on filecoin-project/builtin-actors#1639, but @ZenGround0 , if you can't look this week, please request @Stebalien instead. |
Stebalien
approved these changes
Mar 20, 2025
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
We'll need to test this in lotus against the actual values returned by the new methods, but LGTM!
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 21, 2025
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 21, 2025
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to 🎉 Done
in nv25 Track Board
rjan90
pushed a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 27, 2025
rjan90
pushed a commit
to filecoin-project/lotus
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See filecoin-project/builtin-actors#1639 for the other end of this
PledgePenaltyForContinuedFaultandPledgePenaltyForTerminationmethods and their tests that match the Rust implementation