Skip to content

feat: nv25 and nv26 - fip-0100 (and some FIP-0098)#12932

Merged
rvagg merged 13 commits intomasterfrom
rvagg/fip-0100
Mar 19, 2025
Merged

feat: nv25 and nv26 - fip-0100 (and some FIP-0098)#12932
rvagg merged 13 commits intomasterfrom
rvagg/fip-0100

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Mar 5, 2025

Dev builds of builtin-actors and go-state-types. Still needs a bit more work in actors and we still need a migration and invariants in go-state-types and we need a new ref-fvm to go with it. But we can start looking at work in here too.

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Mar 5, 2025
@rvagg rvagg marked this pull request as draft March 5, 2025 07:26
@github-project-automation github-project-automation Bot moved this to 🐱 Todo in nv25 Track Board Mar 5, 2025
@BigLep BigLep moved this from 🐱 Todo to ⌨️ In Progress in nv25 Track Board Mar 5, 2025
@rvagg rvagg force-pushed the rvagg/fip-0100 branch 5 times, most recently from d61c75e to 70872a7 Compare March 11, 2025 03:18
@rjan90 rjan90 moved this from 📌 Triage to ⌨️ In Progress in FilOz Mar 14, 2025
@rvagg rvagg marked this pull request as ready for review March 17, 2025 04:13
@rvagg rvagg changed the title feat: fip-0100 (WIP) feat: nv25 and nv26 - fip-0100 (and some FIP-0098) Mar 17, 2025
@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Mar 17, 2025

Pulled in #12954 to the bottom of this commit stack, but also has a go-state-types that includes filecoin-project/go-state-types#371 and filecoin-project/go-state-types#372 so we'll need a new RC with those.

@rvagg rvagg moved this from ⌨️ In Progress to 🔎 Awaiting Review in nv25 Track Board Mar 17, 2025
@rvagg rvagg moved this from ⌨️ In Progress to 🔎 Awaiting Review in FilOz Mar 17, 2025
@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Mar 17, 2025

Sadly I think I've introduced a flaky that I'll need to make more robust. After 18 runs locally of #12952 I got a fail:

                Error Trace:    /home/rvagg/go/src/github.com/filecoin-project/lotus/itests/daily_fees_test.go:222
                                                        /home/rvagg/go/src/github.com/filecoin-project/lotus/itests/daily_fees_test.go:625
                Error:          Not equal:
                                expected: 9047612
                                actual  : 8583626
                Test:           TestDailyFees
                Messages:       expected miner to have burned 9047612, but it's burned 8583626

We seem to have run the calculation on the wrong side of a deadline so I'll have to figure out how to be more precise.

@rjan90
Copy link
Copy Markdown
Contributor

rjan90 commented Mar 17, 2025

Been running some migration benchmarks based on this branch here: #12959 (comment). Both in "offline" and "online" modes.

@Stebalien
Copy link
Copy Markdown
Member

Note: I've confirmed that the v16 bundle matches filecoin-project/builtin-actors@cd43784 (one commit behind the target commit due to filecoin-project/builtin-actors#1656, but it's good enough for an RC).

@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Mar 18, 2025

I think this is good to merge (rebase merge pls, I think the commit history is fairly clean). I wouldn't mind @Stebalien having a look at my response above to his last outstanding review. We could deal with it, but we're coping with discrepancies between itest environment and mainnet even though it runs in mainnet mode but with 2k sectors (i.e. params_mainnet) and we have a weird genesis with an initial reserve of 700M. So those changes are to adapt to that and bring it close to mainnet.

@rvagg rvagg force-pushed the rvagg/fip-0100 branch 2 times, most recently from 799d877 to eadab96 Compare March 19, 2025 01:21
@rvagg rvagg force-pushed the rvagg/fip-0100 branch 3 times, most recently from ced6e50 to 72f5d6f Compare March 19, 2025 02:03
@rvagg rvagg merged commit 17067d6 into master Mar 19, 2025
91 checks passed
@rvagg rvagg deleted the rvagg/fip-0100 branch March 19, 2025 02:43
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting Review to 🎉 Done in nv25 Track Board Mar 19, 2025
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants