fix(f3): don't return an error on stop if our context was canceled #12592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the node's `stop` function returns an error and the splitstore and window post dispute tests randomly fail.
8 tasks
Stebalien
added
the
skip/changelog
Stebalien
commented
Oct 11, 2024
masih
approved these changes
Oct 12, 2024
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
…12592) Otherwise, the node's `stop` function returns an error and the splitstore and window post dispute tests randomly fail.
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
…12592) Otherwise, the node's `stop` function returns an error and the splitstore and window post dispute tests randomly fail.
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
…12592) Otherwise, the node's `stop` function returns an error and the splitstore and window post dispute tests randomly fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Don't return an error on stop if our context was canceled. Otherwise, the node's
stopfunction returns an error and the splitstore and window post dispute tests randomly fail.Checklist
Before you mark the PR ready for review, please make sure that: