-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable NAT port mapping, outbound dials, inbound connections #12591
Conversation
0fb6e06
to
3ccfb2b
Compare
3ccfb2b
to
986be16
Compare
This comment was marked as resolved.
This comment was marked as resolved.
My poor network. It deserves to be treated with respect and dignity and doesn't deserve to be spammed. 1. Disable NAT port mapping. Because no, we don't want our integration tests nodes to be reachable. 2. Disable all but a single localhost/quic transport. No need to do more work than necessary. 3. Set the connection manager limits to be really high. This probably doesn't matter, but there's no need to be killing connections in our integration tests. 4. Reject all outbound dials to non-localhost addresses.
986be16
to
3951764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great - want.
The ddo test being flaky here is weird (rerun made it pass) and makes me sus. But is that because of #12592? |
Shouldn't be, this branch is up to date. But I'm also not sure how this change could affect DDO... |
Yeah, just a quick look at the logs it seems like it's something about the miner<>node cooperation in that test. It might not be odd for a flaky, but I don't recall seeing that particular test as flaky, ever. |
Yeah, I haven't seen that before. I'll rerun it a few times and see. |
So, 1 failure for DDO against 4 successes. Looking at the failure, it looks like it took slightly too long:
|
Hm. Although TestOnboardRawPieceSnap is timing out after 10m. Waiting on lotus/itests/direct_data_onboard_test.go Line 388 in f6d4fc7
|
Proposed Changes
My poor network. It deserves to be treated with respect and dignity and doesn't deserve to be spammed.
Checklist
Before you mark the PR ready for review, please make sure that: