-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dagstore lotus mount Implementation with tests #564
Dagstore lotus mount Implementation with tests #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits but LGTM 👍
The mount implementation isn't really specific to lotus, should we call it something other than LotusMount?
@dirkmc Notes on integrating the Sharded DAG Store into Lotus and Markets:
|
@dirkmc Shifting review and TODOs to the |
* refactor: integrate dag store into retrieval market * fix all tests and the padding issue * refactor: move mount from shared testutil to dagstore dir * refactor: add tests for lazy blockstore * refactor: code cleanup * feat: update go-car to latest * Dagstore lotus mount Implementation with tests (#564) * dagstore lotus mount impl * refactor: nicer error messages * mount api tests * refactor: integrate dag store (#565) Co-authored-by: Dirk McCormick <[email protected]> * some storage market fixes by aarsh * fix: better error messages in DAG store wrapper * refactor: simplify mock dag store wrapper * fix: TestBounceConnectionDealTransferOngoing * refactor: remove some commented out code * refactor: closable blockstore interface to use full blockstore * fix: TestBounceConnectionDealTransferUnsealing * refactor: add comment explaining lotus mount template * test: verify that the lazy blockstore is only initialized once * fix: comment * fix: always finalize blockstore before reaching complete state (#567) Co-authored-by: aarshkshah1992 <[email protected]>
* dag store lotus mount * storage client code complete-tests remain * storage miner first draft * second draft * provider state tests are now working * most unit tests working and more unit tests * refactor: car store trackers (#559) * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * nits and review * integration testing changes * storage test harness changes * added more TODOs * fix itests for storage * get offline deal tests working * tests work * more tests * integration tests * fix blockstore finalize * Integrate CARv2 blockstore in the retrieval market (#560) * refactor: integrate dag store into retrieval market * fix all tests and the padding issue * refactor: move mount from shared testutil to dagstore dir * refactor: add tests for lazy blockstore * refactor: code cleanup * feat: update go-car to latest * Dagstore lotus mount Implementation with tests (#564) * dagstore lotus mount impl * refactor: nicer error messages * mount api tests * refactor: integrate dag store (#565) Co-authored-by: Dirk McCormick <[email protected]> * some storage market fixes by aarsh * fix: better error messages in DAG store wrapper * refactor: simplify mock dag store wrapper * fix: TestBounceConnectionDealTransferOngoing * refactor: remove some commented out code * refactor: closable blockstore interface to use full blockstore * fix: TestBounceConnectionDealTransferUnsealing * refactor: add comment explaining lotus mount template * test: verify that the lazy blockstore is only initialized once * fix: comment * fix: always finalize blockstore before reaching complete state (#567) Co-authored-by: aarshkshah1992 <[email protected]> Co-authored-by: dirkmc <[email protected]>
TODO
LotusMount.Stat.Exists
should be false when storage deal expires.