Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor car store trackers #559

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 28, 2021

No description provided.


if bs, ok := r.stores[key]; ok {
return bs, nil
}

return nil, xerrors.New("not found")
return nil, xerrors.Errorf("could not get blockstore for key %s: %w", ErrNotFound)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key isn't logged here.


if bs, ok := r.stores[key]; ok {
return bs, nil
}

return nil, xerrors.New("not found")
return nil, xerrors.Errorf("could not get blockstore for key %s: %w", ErrNotFound)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key isn't logged here.

@aarshkshah1992
Copy link
Collaborator

LGTM ! I'll fix the nits.

@aarshkshah1992 aarshkshah1992 merged commit 9d56cfe into feat/lotus-dagstore-mount Jun 28, 2021
@aarshkshah1992 aarshkshah1992 deleted the refactor/car-store branch June 28, 2021 10:20
aarshkshah1992 added a commit that referenced this pull request Jul 13, 2021
* dag store lotus mount

* storage client code complete-tests remain

* storage miner first draft

* second draft

* provider state tests are now working

* most unit tests working and more unit tests

* refactor: car store trackers (#559)

* Apply suggestions from code review

Co-authored-by: dirkmc <[email protected]>

* nits and review

* integration testing changes

* storage test harness changes

* added more TODOs

* fix itests for storage

* get offline deal tests working

* tests work

* more tests

* integration tests

* fix blockstore finalize

* Integrate CARv2 blockstore in the retrieval market (#560)

* refactor: integrate dag store into retrieval market

* fix all tests and the padding issue

* refactor: move mount from shared testutil to dagstore dir

* refactor: add tests for lazy blockstore

* refactor: code cleanup

* feat: update go-car to latest

* Dagstore lotus mount Implementation with tests (#564)

* dagstore lotus mount impl

* refactor: nicer error messages

* mount api tests

* refactor: integrate dag store (#565)

Co-authored-by: Dirk McCormick <[email protected]>

* some storage market fixes by aarsh

* fix: better error messages in DAG store wrapper

* refactor: simplify mock dag store wrapper

* fix: TestBounceConnectionDealTransferOngoing

* refactor: remove some commented out code

* refactor: closable blockstore interface to use full blockstore

* fix: TestBounceConnectionDealTransferUnsealing

* refactor: add comment explaining lotus mount template

* test: verify that the lazy blockstore is only initialized once

* fix: comment

* fix: always finalize blockstore before reaching complete state (#567)

Co-authored-by: aarshkshah1992 <[email protected]>

Co-authored-by: dirkmc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants