Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass ChannelID to ValidatePush & ValidatePull #220

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 9, 2021

Fixes #209
Closes #219

@codecov-commenter
Copy link

Codecov Report

Merging #220 (b870378) into master (f80db17) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   64.80%   64.92%   +0.12%     
==========================================
  Files          24       24              
  Lines        2648     2646       -2     
==========================================
+ Hits         1716     1718       +2     
+ Misses        585      582       -3     
+ Partials      347      346       -1     
Impacted Files Coverage Δ
impl/events.go 72.75% <100.00%> (-0.20%) ⬇️
impl/restart.go 61.03% <100.00%> (ø)
network/libp2p_impl.go 72.26% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80db17...b870378. Read the comment docs.

Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race between OnDataQueued and Accept event
3 participants