Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pdp updates -- nextProvingPeriod called after first add #347

Merged
merged 39 commits into from
Jan 28, 2025

Conversation

ZenGround0
Copy link
Collaborator

This is an attempt to bring curio up to date with the latest changes here: FilOzone/pdp#86. The main difference is that now pdp add does not register a challenge generation, that must happen explicitly through a call to nextprovingperiod.

The approach here is

  1. Create a new harmony task just for initializing proof sets with first call to nextProvingPeriod
  2. Differentiate these jobs from regular nextProvingPeriod jobs by checking that prove_at_epoch IS NULL
  3. initProvingPeriod jobs also guarded on new proofset schema column boolean flag init_ready being set to true, which happens on the first add

@ZenGround0 ZenGround0 requested a review from magik6k December 17, 2024 15:19
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads correctly, so if it works should be fine to merge

@ZenGround0 ZenGround0 requested a review from magik6k January 26, 2025 10:26
@ZenGround0
Copy link
Collaborator Author

Ok @magik6k I've finally got this consistently proving. Please give it another review.

@magik6k magik6k merged commit 88659ba into feat/pdp Jan 28, 2025
13 of 14 checks passed
@magik6k magik6k deleted the feat/integrate-pdp-codefreeze branch January 28, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants