Remove special casing of first add #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ampling and proving respectively
ZenGround0
force-pushed
the
feat/first-add-ur-not-special
branch
from
c2de7f2 to
c9fc9e5
Compare
There was a problem hiding this comment.
@ZenGround0 Left first round of comments. Will do one more round once you address these.
src/PDPVerifier.sol
Outdated
| @@ -388,6 +384,8 @@ contract PDPVerifier is Initializable, UUPSUpgradeable, OwnableUpgradeable { | |||
| uint256 challengeEpoch = nextChallengeEpoch[setId]; | |||
| require(block.number >= challengeEpoch, "premature proof"); | |||
| require(proofs.length > 0, "empty proof"); | |||
| require(challengeEpoch != NO_CHALLENGE_SCHEDULED, "no challenge scheduled"); | |||
| require(proofSetOwner[setId] == msg.sender, "only the owner can prove possession"); | |||
There was a problem hiding this comment.
@ZenGround0 This check already exists above and is a duplicate.
aarshkshah1992
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
@ZenGround0 Lgtm. Just need to fix the duplicate check for owner in provePossesion in the PDPVerifier contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #