fix: handle errors and non-existent addresses in selfdestruct #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on #896. |
Stebalien
force-pushed
the
steb/fix-selfdestruct
branch
from
d6fcade
to
64a8b15
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Stebalien
force-pushed
the
steb/refactor-table
branch
from
ddd6e5f
to
b76083c
Compare
Stebalien
force-pushed
the
steb/fix-selfdestruct
branch
2 times, most recently
from
8fce85c
to
36d55b0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## steb/refactor-table #897 +/- ##
=======================================================
+ Coverage 86.89% 86.96% +0.06%
=======================================================
Files 127 127
Lines 23714 23717 +3
=======================================================
+ Hits 20607 20625 +18
+ Misses 3107 3092 -15
|
vyzo
approved these changes
Dec 2, 2022
Stebalien
force-pushed
the
steb/refactor-table
branch
2 times, most recently
from
d6448db
to
a441f44
Compare
In the EVM: 1. Self destruct continues even if it sends funds into oblivion. 2. Self destruct will auto-create a beneficiary. This lets us punt filecoin-project/ref-fvm#736 to M2.2.
Stebalien
force-pushed
the
steb/fix-selfdestruct
branch
from
36d55b0
to
d678787
Compare
Stebalien
added a commit
that referenced
this pull request
Dec 2, 2022
In the EVM: 1. Self destruct continues even if it sends funds into oblivion. 2. Self destruct will auto-create a beneficiary. This lets us punt filecoin-project/ref-fvm#736 to M2.2.
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the EVM:
This lets us punt filecoin-project/ref-fvm#736 to M2.2.