refactor: rework opcodes definitions and control flow #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #896 +/- ##
==========================================
+ Coverage 86.87% 86.89% +0.02%
==========================================
Files 127 127
Lines 23695 23714 +19
==========================================
+ Hits 20585 20607 +22
+ Misses 3110 3107 -3
|
Stebalien
force-pushed
the
steb/refactor-table
branch
from
ddd6e5f
to
b76083c
Compare
Stebalien
commented
Dec 2, 2022
| /// Indicates the "outcome" of the execution. | ||
| pub outcome: Outcome, | ||
| /// The return data. | ||
| pub return_data: Bytes, | ||
| } | ||
|
|
||
| /// Message status code. | ||
| #[must_use] | ||
| #[derive(Clone, Debug, Display, PartialEq, Eq)] | ||
| pub enum StatusCode { |
There was a problem hiding this comment.
Note: I'm planning on renaming this in a follow up PR (to Error), but I don't want that much churn in this PR.
vyzo
approved these changes
Dec 2, 2022
Stebalien
force-pushed
the
steb/refactor-table
branch
from
b76083c
to
d6448db
Compare
My goal here was simplify the logic around "exiting" so that I could reason about it. Specifically, so I could fix some issues with SELFDESTRUCT. We had multiple error and success paths and that made me nervous. In the process, I ended up changing a bunch of other things: 1. Exit early by setting the PC. 2. Go back to propagating the error through `step()` (makes things easier to read). 3. Fix some rust unsafety things. 4. Move _all_ of the instruction specific logic into the instruction definitions. This will let us eventually remove one of these tables. - This means that instructions manage their own PCs. 5. Aggressively inline.
Stebalien
force-pushed
the
steb/refactor-table
branch
from
d6448db
to
a441f44
Compare
Stebalien
added a commit
that referenced
this pull request
Dec 2, 2022
My goal here was simplify the logic around "exiting" so that I could reason about it. Specifically, so I could fix some issues with SELFDESTRUCT. We had multiple error and success paths and that made me nervous. In the process, I ended up changing a bunch of other things: 1. Exit early by setting the PC. 2. Go back to propagating the error through `step()` (makes things easier to read). 3. Fix some rust unsafety things. 4. Move _all_ of the instruction specific logic into the instruction definitions. This will let us eventually remove one of these tables. - This means that instructions manage their own PCs. 5. Aggressively inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal here was simplify the logic around "exiting" so that I could reason about it. Specifically, so I could fix some issues with SELFDESTRUCT. We had multiple error and success paths and that made me nervous.
In the process, I ended up changing a bunch of other things:
step()(makes things easier to read).