Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add batch registration to Almanac API and Almanac Contract #571

Closed
wants to merge 9 commits into from

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Oct 28, 2024

Proposed Changes

When running the Bureau, the Bureau will now use the Almanac API's batch registration endpoint by default to register all agents in a single request. Additionally, if a wallet is provided in the Bureau's init args, it will also send the Almanac contract registration transactions in a batch. By default, with no wallet address provided, the agents will register themselves as before, so this update should be fully backwards compatible.

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

@jrriehl jrriehl marked this pull request as ready for review October 28, 2024 17:14
@jrriehl
Copy link
Contributor Author

jrriehl commented Oct 29, 2024

All changes included in #551.

@jrriehl jrriehl closed this Oct 29, 2024
@jrriehl jrriehl deleted the feat/ledger-batch-registration branch October 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant