-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add batch almanac api and contract registrations for Bureau #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
I just have two minor comments/discussion points but other than that I'm good with the feature 👍🏻
…ger-batch-registration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Also a lot of changes have been made so I hope to have gotten every detail.
The only thing that stood out for me is the handling of metadata as I think that has not been decided yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Proposed Changes
When running the Bureau, the Bureau will now use the Almanac API's batch registration endpoint by default to register all agents in a single request. Additionally, if a wallet is provided in the Bureau's init args, it will also send the Almanac contract registration transactions in a batch. By default, with no wallet address provided, the agents will register themselves as before, so this update should be fully backwards compatible.
Types of changes
What type of change does this pull request make (put an
x
in the boxes that apply)?Checklist
Put an
x
in the boxes that apply:If applicable