Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add batch almanac api and contract registrations for Bureau #551

Merged
merged 18 commits into from
Nov 8, 2024

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Oct 11, 2024

Proposed Changes

When running the Bureau, the Bureau will now use the Almanac API's batch registration endpoint by default to register all agents in a single request. Additionally, if a wallet is provided in the Bureau's init args, it will also send the Almanac contract registration transactions in a batch. By default, with no wallet address provided, the agents will register themselves as before, so this update should be fully backwards compatible.

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

@jrriehl jrriehl marked this pull request as ready for review October 11, 2024 16:15
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

I just have two minor comments/discussion points but other than that I'm good with the feature 👍🏻

python/src/uagents/registration.py Outdated Show resolved Hide resolved
python/src/uagents/registration.py Outdated Show resolved Hide resolved
@jrriehl jrriehl changed the title feat(core): add batch almanac api registrations for Bureau feat(core): add batch almanac api and contract registrations for Bureau Oct 29, 2024
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Also a lot of changes have been made so I hope to have gotten every detail.
The only thing that stood out for me is the handling of metadata as I think that has not been decided yet.

python/src/uagents/agent.py Show resolved Hide resolved
python/src/uagents/registration.py Outdated Show resolved Hide resolved
python/src/uagents/registration.py Outdated Show resolved Hide resolved
Archento
Archento previously approved these changes Oct 29, 2024
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jrriehl jrriehl merged commit 1b67a4f into main Nov 8, 2024
9 checks passed
@jrriehl jrriehl deleted the feat/batch-registrations branch November 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants