Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema push #371

Merged
merged 3 commits into from
Oct 2, 2024
Merged

add schema push #371

merged 3 commits into from
Oct 2, 2024

Conversation

echo-bravo-yahoo
Copy link
Contributor

No description provided.

Copy link
Contributor

@macmv macmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nitpicks. also, i'm curious: does the new CLI use typescript, or is it all vanilla JS?


const json = await res.json();
if (json.error) {
logger.stderr(json.error?.message ?? json.error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this fails, the command should exit. does logger.stderr cause the command to exit immediately?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not - the schema commands right now are very WIP.

@echo-bravo-yahoo
Copy link
Contributor Author

just a few nitpicks. also, i'm curious: does the new CLI use typescript, or is it all vanilla JS?

currently, the new CLI is vanilla ESM. no build, no bundler.

i expect we'll add esbuild before release for distribution reasons and lean on JSDoc => intellisense for code assistance in the repo.

@wildemat wildemat merged commit 48eb7ac into v3 Oct 2, 2024
1 check failed
@wildemat wildemat deleted the schema branch October 2, 2024 13:07
@wildemat wildemat mentioned this pull request Oct 2, 2024
echo-bravo-yahoo added a commit that referenced this pull request Oct 4, 2024
* add schema push command

* add schema pull, status commands

* address pr feedback
This was referenced Nov 18, 2024
@cleve-fauna cleve-fauna mentioned this pull request Nov 22, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants