-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add schema push #371
add schema push #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nitpicks. also, i'm curious: does the new CLI use typescript, or is it all vanilla JS?
|
||
const json = await res.json(); | ||
if (json.error) { | ||
logger.stderr(json.error?.message ?? json.error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this fails, the command should exit. does logger.stderr
cause the command to exit immediately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not - the schema commands right now are very WIP.
currently, the new CLI is vanilla ESM. no build, no bundler. i expect we'll add esbuild before release for distribution reasons and lean on JSDoc => intellisense for code assistance in the repo. |
b9652a4
to
9726693
Compare
* add schema push command * add schema pull, status commands * address pr feedback
No description provided.