Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login test #372

Merged
merged 10 commits into from
Oct 3, 2024
Merged

login test #372

merged 10 commits into from
Oct 3, 2024

Conversation

wildemat
Copy link
Contributor

@wildemat wildemat commented Oct 2, 2024 •
edited
Loading

Ticket(s): FE-5860

Problem

  • Error handling and logging need improvements
  • No test for login

Solution

  • Mock things and test what login spits out to customer
  • Improved error handling and logging middleware

Result

➜  fauna-shell git:(login-test) ./node_modules/.bin/mocha ./yargs-test/login.mjs --recursive


  login command
    ✔ can login


  1 passing (15ms)

Testing

Ran the new test

@wildemat wildemat changed the base branch from main to v3 October 2, 2024 17:32
@wildemat wildemat marked this pull request as ready for review October 3, 2024 17:13
@wildemat wildemat merged commit dfcdd66 into v3 Oct 3, 2024
1 check failed
@wildemat wildemat deleted the login-test branch October 3, 2024 17:16
echo-bravo-yahoo added a commit that referenced this pull request Oct 4, 2024
@wildemat @echo-bravo-yahoo
login test (#372)
d0c8039 
* improve schema commands, add fetch wrapper, add verbosity controls

* breakout frontdoor client and get login working

* improve error handling, logging, standardize help text capitalization

* wip

* wip

* wip

* finish error handling tests, behavior

* more fixes

* basic login test with mocked oauth and account

---------

Co-authored-by: Ashton Eby <[email protected]>
This was referenced Nov 18, 2024
Merged
Merged
@cleve-fauna cleve-fauna mentioned this pull request Nov 22, 2024
Closed
@wildemat wildemat mentioned this pull request Nov 22, 2024
Merged
This was referenced Dec 2, 2024
Merged
Merged
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
Closed
This was referenced Dec 6, 2024
Merged
Closed
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
Closed
@wildemat wildemat mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echo-bravo-yahoo echo-bravo-yahoo Awaiting requested review from echo-bravo-yahoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wildemat @echo-bravo-yahoo